-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Text.Json source gen containing non-localized error messages #58292
Comments
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsFor example
We should find all such messages and localize them.
|
We need to determine if these error messages are displayed at design-time. If they occur at design-time they should be localized. However, in the referenced example above, the exception with the non-localized message occurs at run-time within the generated code which I believe should not be localized because we don't localize other exception messages in STJ that occur at run-time. In theory, at run-time the generated code and STJ are interchangeable (logic could exist on either side, and may change in the future) and should be indistinguishable from the user and thus should throw non-localized exception messages. |
For example
runtime/src/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs
Line 793 in 3e6d492
We should find all such messages and localize them.
The text was updated successfully, but these errors were encountered: