Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running test assemblies in parallel in the same xunit process #59821

Open
ericstj opened this issue Sep 30, 2021 · 2 comments
Open

Avoid running test assemblies in parallel in the same xunit process #59821

ericstj opened this issue Sep 30, 2021 · 2 comments

Comments

@ericstj
Copy link
Member

ericstj commented Sep 30, 2021

As mentioned in #11063 (comment)

We shouldn't be relying on concurrent execution of test assemblies in the xunit runner on non .NETFramework. We've hit multiple issues because of this:
#11320
#11063

We've gotten some patches into xunit to avoid these, but we should avoid the to get on the "happy path" for this component otherwise we're likely to hit more issues.

I believe the primary place where we do pass multiple assemblies is in the runtime tests. I believe those could be modified to use a single test assembly and avoid this case. AFICT they aren't even running tests in the Xunit process so it should be feasible to either generate them as a single assembly, or generate the wrapper in a different way so that it doesn't appear to xunit as multiple test assemblies.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Sep 30, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Sep 30, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

As mentioned in #11063 (comment)

We shouldn't be relying on concurrent execution of test assemblies in the xunit runner on non .NETFramework. We've hit multiple issues because of this:
#11320
#11063

We've gotten some patches into xunit to avoid these, but we should avoid the to get on the "happy path" for this component otherwise we're likely to hit more issues.

I believe the primary place where we do pass multiple assemblies is in the runtime tests. I believe those could be modified to use a single test assembly and avoid this case. AFICT they aren't even running tests in the Xunit process so it should be feasible to either generate them as a single assembly, or generate the wrapper in a different way so that it doesn't appear to xunit as multiple test assemblies.

Author: ericstj
Assignees: -
Labels:

area-Infrastructure-coreclr, untriaged

Milestone: -

@ericstj ericstj added this to the 7.0.0 milestone Sep 30, 2021
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Oct 7, 2021
@agocke agocke modified the milestones: 7.0.0, Future Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants