Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono leaks native errno value during UnmanagedCallersOnly prolog/epilog #60271

Open
jkoritzinsky opened this issue Oct 11, 2021 · 2 comments
Open
Assignees
Milestone

Comments

@jkoritzinsky
Copy link
Member

This causes the DllImportGenerator.IntegrationTests.SetLastErrorTests.ClearPreviousError test to fail intermittently when run on Mono (this hit on CI, but did not hit in local testing).

Related to #51600 and #59721

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Oct 11, 2021
@lambdageek lambdageek added this to the 7.0.0 milestone Oct 13, 2021
@lambdageek lambdageek removed the untriaged New issue has not been triaged by the area owner label Oct 13, 2021
@lambdageek
Copy link
Member

Not super clear where we pollute errno. Perhaps here

/* mono_threads_detach_coop (orig_domain, &attach_cookie); */
mono_mb_emit_ldloc (mb, orig_domain);
mono_mb_emit_ldloc_addr (mb, attach_cookie);
/* Special cased in interpreter, keep in sync */
mono_mb_emit_icall (mb, mono_threads_detach_coop);

@SamMonoRT
Copy link
Member

@BrzVlad - assigning to you, possibly might be fixed by your ongoing changes in interop area. Moving to 8.0.0 too.

@SamMonoRT SamMonoRT modified the milestones: 7.0.0, 8.0.0 Aug 12, 2022
@marek-safar marek-safar modified the milestones: 8.0.0, 9.0.0 Jul 24, 2023
@agocke agocke modified the milestones: 9.0.0, Future Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

6 participants