-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mono ARM64 JIT inconsistent with sign-extension #60649
Comments
This is failing rolling builds -- if this was a recently introduced regression, can we revert and resubmit? |
This is a long standing bug that was discovered by merging in the DllImportGenerator. We can add an |
Either disabling the issue or reverting the DllImport merge would be good. Whichever one we choose should be based on whether this issue would be considered blocking |
I think that given the scope of the merge, disabling the test is the correct approach. |
At this point, I think disabling the test is fine. @fanyang-mono to follow up. We should also figure out if the test lanes were enabled as part of PR runs, why this wasn't caught prior to merging. (Totally understand if this is a rolling build only test run). |
Moving to 9.0.0 |
The DllImportGenerator test DllImportGenerator.IntegrationTests.BooleanTests.ValidateBoolIsMarshalledAsExpected fails on Mono ARM64 due to inconsistencies with sign extension.
This assert fails:
runtime/src/libraries/System.Runtime.InteropServices/tests/DllImportGenerator.Tests/BooleanTests.cs
Line 99 in 9362323
runtime/src/libraries/System.Runtime.InteropServices/tests/TestAssets/NativeExports/Booleans.cs
Line 19 in b201a16
Runfo Tracking Issue: DllImportGenerator.IntegrationTests.BooleanTests.ValidateBoolIsMarshalledAsExpected
Build Result Summary
The text was updated successfully, but these errors were encountered: