Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DllImportGenerator] Support down-level targets #60662

Closed
Tracked by #60212
jkoritzinsky opened this issue Oct 20, 2021 · 2 comments · Fixed by #61064
Closed
Tracked by #60212

[DllImportGenerator] Support down-level targets #60662

jkoritzinsky opened this issue Oct 20, 2021 · 2 comments · Fixed by #61064
Assignees
@AaronRobinsonMSFT
Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Milestone
7.0.0

Comments

@jkoritzinsky
Copy link
Member

jkoritzinsky commented Oct 20, 2021 •
edited
Loading

Allow each marshaller to specify its support
Fall back to generating partial extern p/invoke if target version is less than required
@jkoritzinsky jkoritzinsky mentioned this issue Oct 20, 2021
Closed
13 tasks
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Oct 20, 2021
@jkoritzinsky jkoritzinsky changed the title Support down-level targets [DllImportGenerator] Support down-level targets Oct 20, 2021
@jkoritzinsky jkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature and removed untriaged New issue has not been triaged by the area owner labels Oct 20, 2021
@jkoritzinsky jkoritzinsky added this to the 7.0.0 milestone Oct 20, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this issue Nov 1, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 1, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 3, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Add TFM and version support query to marshaller interface. AaronRobinsonMSFT/runtime
3 participants
@jkoritzinsky @AaronRobinsonMSFT and others