Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Fix failing tests after nested static class evaluation fix. #61509

Closed
35 tasks done
ilonatommy opened this issue Nov 12, 2021 · 2 comments
Closed
35 tasks done

[wasm][debugger] Fix failing tests after nested static class evaluation fix. #61509

ilonatommy opened this issue Nov 12, 2021 · 2 comments
Assignees
@ilonatommy
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Milestone
7.0.0

Comments

@ilonatommy
Copy link
Member

ilonatommy commented Nov 12, 2021 •
edited
Loading

Based on ilonatommy:add-nested-static-attribute-support branch , fix failing tests. Afterwards, complete PR for nested static classes (#61508). Names of tests:

  • DebuggerTests.AsyncTests.AsyncLocalsInContinueWith
  • DebuggerTests.AsyncTests.AsyncLocalsInContinueWithInstanceUsingThisBlock
  • DebuggerTests.AsyncTests.AsyncLocalsInNestedContinueWithStaticBlock
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateTypeInstanceMembers
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsError
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateExpressionsWithDeepMemberAccesses
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateInstanceMethodArguments
  • DebuggerTests.EvaluateOnCallFrameTests.NegativeTestsInInstanceMethod
  • DebuggerTests.EvaluateOnCallFrameTests.LocalsAndArgsShadowingThisMembers
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateMethodLocals
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateStaticClassInvalidField
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateStaticClass
  • DebuggerTests.EvaluateOnCallFrameTests.AsyncLocalsInContinueWithBlock
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsWithVariableParms
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsWithConstParms
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsCheckChangedValue
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsWithoutParms
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateLocalsAsync
  • DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleExpressions
  • DebuggerTests.SteppingTests.ResumeOutOfAsyncMethodToAsyncCallerWithBreakpoint
  • DebuggerTests.SteppingTests.BreakOnAwaitThenResumeToNextBreakpoint
  • DebuggerTests.SteppingTests.BreakOnAwaitThenResumeToNextBreakpointAfterSecondAwaitInSameMethod
  • DebuggerTests.SteppingTests.BreakOnAwaitThenStepOverToNextAwaitCall
  • DebuggerTests.SteppingTests.InspectValueTypeMethodArgsWhileStepping
  • DebuggerTests.SteppingTests.BreakOnAwaitThenStepOverToNextLine
  • DebuggerTests.SourceList.InspectNullableLocals
  • DebuggerTests.SourceList.InspectBoxedAsClassLocals
  • DebuggerTests.SourceList.EmptyTypeWithNoLocalsOrParams
  • DebuggerTests.SourceList.StaticMethodWithLocalEmptyStructThatWillGetExpanded
  • DebuggerTests.SourceList.InspectTaskAtLocals
  • DebuggerTests.SourceList.InspectBoxedTypeObject
  • DebuggerTests.SourceList.InspectBoxedLocals
  • DebuggerTests.SourceList.InspectLocalsWithGenericTypesAtBreakpointSite
  • DebuggerTests.SourceList.InspectLocalsWithStructs
  • DebuggerTests.SourceList.InspectLocalsWithStructsStaticAsync
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Nov 12, 2021
@ilonatommy ilonatommy self-assigned this Nov 12, 2021
@ghost
Copy link

ghost commented Nov 12, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on ilonatommy:add-nested-static-attribute-support branch , fix 83 failing tests. Afterwards, complete PR for nested static classes Names of tests:

DebuggerTests.AsyncTests.AsyncLocalsInContinueWith
DebuggerTests.AsyncTests.AsyncLocalsInContinueWithInstanceUsingThisBlock
DebuggerTests.AsyncTests.AsyncLocalsInNestedContinueWithStaticBlock
DebuggerTests.EvaluateOnCallFrameTests.EvaluateTypeInstanceMembers
DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsError
DebuggerTests.EvaluateOnCallFrameTests.EvaluateExpressionsWithDeepMemberAccesses
DebuggerTests.EvaluateOnCallFrameTests.EvaluateInstanceMethodArguments
DebuggerTests.EvaluateOnCallFrameTests.NegativeTestsInInstanceMethod
DebuggerTests.EvaluateOnCallFrameTests.LocalsAndArgsShadowingThisMembers
DebuggerTests.EvaluateOnCallFrameTests.EvaluateMethodLocals
DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleExpressions
DebuggerTests.EvaluateOnCallFrameTests.EvaluateStaticClassInvalidField
DebuggerTests.EvaluateOnCallFrameTests.EvaluateStaticClass
DebuggerTests.EvaluateOnCallFrameTests.AsyncLocalsInContinueWithBlock
DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsWithVariableParms
DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsWithConstParms
DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsCheckChangedValue
DebuggerTests.EvaluateOnCallFrameTests.EvaluateSimpleMethodCallsWithoutParms
DebuggerTests.EvaluateOnCallFrameTests.EvaluateLocalsAsync
DebuggerTests.SteppingTests.ResumeOutOfAsyncMethodToAsyncCallerWithBreakpoint
DebuggerTests.SteppingTests.BreakOnAwaitThenResumeToNextBreakpoint
DebuggerTests.SteppingTests.BreakOnAwaitThenResumeToNextBreakpointAfterSecondAwaitInSameMethod
DebuggerTests.SteppingTests.BreakOnAwaitThenStepOverToNextAwaitCall
DebuggerTests.SteppingTests.BreakOnAwaitThenStepOverToNextLine
DebuggerTests.SourceList.InspectNullableLocals
DebuggerTests.SourceList.InspectBoxedAsClassLocals
DebuggerTests.SourceList.EmptyTypeWithNoLocalsOrParams
DebuggerTests.SourceList.StaticMethodWithLocalEmptyStructThatWillGetExpanded
DebuggerTests.SourceList.InspectTaskAtLocals
DebuggerTests.SourceList.InspectBoxedTypeObject
DebuggerTests.SourceList.InspectBoxedLocals

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 12, 2021
@lewing lewing added this to the 7.0.0 milestone Nov 12, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Nov 15, 2021
This was referenced Nov 19, 2021
Closed
Merged
Merged
@ilonatommy
Copy link
Member Author

All tests fixed.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@lewing @ilonatommy