Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should expose the accumulative GC pause duration as a counter #69324

Closed
Maoni0 opened this issue May 13, 2022 · 5 comments · Fixed by #88699
Closed

should expose the accumulative GC pause duration as a counter #69324

Maoni0 opened this issue May 13, 2022 · 5 comments · Fixed by #88699
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@Maoni0
Copy link
Member

Maoni0 commented May 13, 2022

essentially expose what's implemented in this API that @cshung is working on. this should replace the current % time in GC since last GC which is simply not a good counter. see explanation here.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 13, 2022
@ghost
Copy link

ghost commented May 13, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

essentially expose what's implemented in this API that @cshung is working on. this should replace the current % time in GC since last GC which is simply not a good counter. see explanation here.

Author: Maoni0
Assignees: -
Labels:

area-GC-coreclr, untriaged

Milestone: -

@ghost
Copy link

ghost commented May 13, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

essentially expose what's implemented in this API that @cshung is working on. this should replace the current % time in GC since last GC which is simply not a good counter. see explanation here.

Author: Maoni0
Assignees: -
Labels:

area-Diagnostics-coreclr, area-GC-coreclr, untriaged

Milestone: -

@Maoni0
Copy link
Member Author

Maoni0 commented May 13, 2022

@tommcdon could someone from your team please add this?

@tommcdon
Copy link
Member

@Maoni0 thanks for the suggestion! Adding @mikelle-rogers to take a look.

@tommcdon tommcdon added this to the 7.0.0 milestone May 13, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label May 13, 2022
@tommcdon tommcdon added enhancement Product code improvement that does NOT require public API changes/additions untriaged New issue has not been triaged by the area owner and removed untriaged New issue has not been triaged by the area owner labels May 13, 2022
@joaocpaiva
Copy link

+1

Having a reliable counter to track the relative cost of GC pauses is important to identify regressions or validate improvements, as it reflects in tail latency and CPU. And for cloud services, tracking the relative cost of GC becomes paramount, especially for latency-sensitive workloads. Please prioritize this accordingly.

@tommcdon tommcdon modified the milestones: 7.0.0, Future Jun 21, 2022
@tommcdon tommcdon modified the milestones: Future, 8.0.0 Jul 10, 2023
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 11, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants