-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Int128/UInt128 interop tests for Mono #69531
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
The android tests in particular were failing because they can't find the corresponding native library: The iOS and tvOS tests didn't run as the jobs hit other more general issues, such as timeouts at 240 minutes. |
@tannergooding do you remember if this issue is caused by #69399 |
That's the main issue AFAIK, but there may be other issues.
|
#69204 introduced the
Int128
andUInt128
types and included interop tests validating they are passed correctly to/from native.However, they are currently disabled for Mono as are a large number of the
Interop/PInvoke/*
tests. These tests need to be enabled for Mono to ensure that these types work correctly in Interop scenarios.The other
Interop/PInvoke/*
tests should likely be looked at as well since a majority of them currently appear to be disabled. See https://github.com/dotnet/runtime/blob/main/src/tests/issues.targets#L1716-L1772 under https://github.com/dotnet/runtime/blob/main/src/tests/issues.targets#L1446-L1447The text was updated successfully, but these errors were encountered: