Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Int128/UInt128 interop tests for Mono #69531

Open
tannergooding opened this issue May 19, 2022 · 4 comments
Open

Enable Int128/UInt128 interop tests for Mono #69531

tannergooding opened this issue May 19, 2022 · 4 comments
Assignees
Labels
area-Interop-mono disabled-test The test is disabled in source code against the issue
Milestone

Comments

@tannergooding
Copy link
Member

#69204 introduced the Int128 and UInt128 types and included interop tests validating they are passed correctly to/from native.

However, they are currently disabled for Mono as are a large number of the Interop/PInvoke/* tests. These tests need to be enabled for Mono to ensure that these types work correctly in Interop scenarios.

The other Interop/PInvoke/* tests should likely be looked at as well since a majority of them currently appear to be disabled. See https://github.com/dotnet/runtime/blob/main/src/tests/issues.targets#L1716-L1772 under https://github.com/dotnet/runtime/blob/main/src/tests/issues.targets#L1446-L1447

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 19, 2022
@tannergooding
Copy link
Member Author

The android tests in particular were failing because they can't find the corresponding native library: System.DllNotFoundException: Int128Native.

The iOS and tvOS tests didn't run as the jobs hit other more general issues, such as timeouts at 240 minutes.

@BrzVlad
Copy link
Member

BrzVlad commented Jul 23, 2022

@tannergooding do you remember if this issue is caused by #69399

@tannergooding
Copy link
Member Author

That's the main issue AFAIK, but there may be other issues.

Int128/UInt128 in particular are the "ABI primitive" types and so they may need special handling in the LLVM/Mono backend (same goes for Vector64/128/256<T>).

@BrzVlad BrzVlad modified the milestones: 7.0.0, 8.0.0 Aug 12, 2022
@marek-safar marek-safar modified the milestones: 8.0.0, 9.0.0 Jul 24, 2023
@SamMonoRT SamMonoRT removed their assignment Feb 8, 2024
@BrzVlad BrzVlad modified the milestones: 9.0.0, Future Aug 6, 2024
@agocke agocke added this to AppModel Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Interop-mono disabled-test The test is disabled in source code against the issue
Projects
Status: No status
Development

No branches or pull requests

5 participants