Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate removing gtSimdBaseJitType from GenTreeVecCon #70052

Closed
tannergooding opened this issue May 31, 2022 · 3 comments · Fixed by #74580
Closed

Investigate removing gtSimdBaseJitType from GenTreeVecCon #70052

tannergooding opened this issue May 31, 2022 · 3 comments · Fixed by #74580
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
8.0.0

Comments

@tannergooding
Copy link
Member

#68874 introduced a new GenTreeVecCon node and it currently carries a gtSimdBaseJitType field so that a handle can be reconstituted where required.

As per #68874 (comment), #69971 likely removed the need to carry this information around and so we should remove the field if that is indeed the case.
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 31, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@tannergooding tannergooding mentioned this issue May 31, 2022
Merged
@SingleAccretion SingleAccretion added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 31, 2022
@ghost
Copy link

ghost commented May 31, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

#68874 introduced a new GenTreeVecCon node and it currently carries a gtSimdBaseJitType field so that a handle can be reconstituted where required.

As per #68874 (comment), #69971 likely removed the need to carry this information around and so we should remove the field if that is indeed the case.

Author: tannergooding
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Jun 8, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone Jun 8, 2022
@JulieLeeMSFT
Copy link
Member

cc @dotnet/jit-contrib.

@SingleAccretion SingleAccretion mentioned this issue Aug 25, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 25, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
8.0.0
3 participants
@tannergooding @SingleAccretion @JulieLeeMSFT