Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP/3] Initialize MsQuic only when HTTP3 will be used to send the request. #76445

Closed
rzikm opened this issue Sep 30, 2022 · 2 comments · Fixed by #83494
Closed

[HTTP/3] Initialize MsQuic only when HTTP3 will be used to send the request. #76445

rzikm opened this issue Sep 30, 2022 · 2 comments · Fixed by #83494
Assignees
@wfurt
Labels
area-System.Net.Http
Milestone
8.0.0

Comments

@rzikm
Copy link
Member

rzikm commented Sep 30, 2022 •
edited by ManickaP
Loading

Based on discussions around #74629, #75163 and others. Concrete feedback in #75330 (comment)

Currently, we initialize MsQuic even if HTTP3 is not considered, e.g., a lower HTTP version is set and the VersionPolicy does not allow upgrade. We do so because we precompute some data for use in HTTP3 if HTTP3 is supported (like serialized SETTINGS frame to be sent over the wire).

We should look at those places and see if it is possible to initialize MsQuic only if HTTP3 ends up actually being used to send the request.
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 30, 2022
@ghost
Copy link

ghost commented Sep 30, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Based on discussions around #74629, #75163 and others.

Currently, we initialize MsQuic even if HTTP3 is not considered, e.g., a lover HTTP version is set and the VersionPolicy does not allow upgrade. We do so because we precompute some data for use in HTTP3 if HTTP3 is supported (like serialized SETTINGS frame to be sent over the wire).

We should look at those places and see if it is possible to initialize MsQuic only if HTTP3 ends up actually being used to send the request.

Author: rzikm
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@rzikm rzikm changed the title Initialize MsQuic less often [HTTP3] Initialize MsQuic only when HTTP3 will be used to send the request. Sep 30, 2022
@ManickaP ManickaP changed the title [HTTP3] Initialize MsQuic only when HTTP3 will be used to send the request. [HTTP/3] Initialize MsQuic only when HTTP3 will be used to send the request. Oct 3, 2022
@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label Oct 3, 2022
@ManickaP ManickaP added this to the 8.0.0 milestone Oct 3, 2022
@ManickaP
Copy link
Member

Triage: we already solved the main issue in #74629, this is nice to have on top of that. Leaving in 8.0, but with low priority.

@wfurt wfurt self-assigned this Mar 16, 2023
@wfurt wfurt mentioned this issue Mar 16, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 16, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wfurt wfurt

Labels
area-System.Net.Http
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

don't load MsQuic unless needed by HttpClient wfurt/runtime
3 participants
@ManickaP @wfurt @rzikm