Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Support indexing by object schema #77536

Closed
2 of 3 tasks
Tracked by #90587
ilonatommy opened this issue Oct 27, 2022 · 2 comments
Closed
2 of 3 tasks
Tracked by #90587

[wasm][debugger] Support indexing by object schema #77536

ilonatommy opened this issue Oct 27, 2022 · 2 comments
Labels
arch-wasm WebAssembly architecture area-Debugger-mono enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@ilonatommy
Copy link
Member

ilonatommy commented Oct 27, 2022

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Oct 27, 2022
@ilonatommy ilonatommy self-assigned this Oct 27, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 27, 2022
@ghost
Copy link

ghost commented Oct 27, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

E.g. add test: await EvaluateOnCallFrame(id, "f[o]" ); to EvaluateObjectByNonIntLocals where object o = 'c'; and f has a property: public object this[object key] => key;. And some more, for a few other object scheme (valuetype and array as well, if it won't make this PR too big).

The result:

  "result": {
    "type": "string",
    "value": "res_c",
    "description": "res_c",
    "objectId": "dotnet:object:"
  }

Reason:
we are keeping indexes in a form of strings. They cannot keep all the information about the indexer if it's an object. We need to start supporting more complex entities.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@lewing lewing added this to the 9.0.0 milestone Jul 11, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jul 11, 2023
@thaystg thaystg added the enhancement Product code improvement that does NOT require public API changes/additions label Mar 4, 2024
@ilonatommy ilonatommy removed their assignment Apr 25, 2024
@ilonatommy ilonatommy modified the milestones: 9.0.0, Future Apr 25, 2024
@thaystg
Copy link
Member

thaystg commented Aug 6, 2024

This is fixed by the new debugger.

@thaystg thaystg closed this as completed Aug 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

3 participants