Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][tests] Hybrid.WASM.Tests SIGSEGV failure on iOS #84477

Closed
kotlarmilos opened this issue Apr 7, 2023 · 3 comments · Fixed by #84616
Closed

[mono][tests] Hybrid.WASM.Tests SIGSEGV failure on iOS #84477

kotlarmilos opened this issue Apr 7, 2023 · 3 comments · Fixed by #84616
Assignees
Labels
area-Infrastructure-mono blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Milestone

Comments

@kotlarmilos
Copy link
Member

kotlarmilos commented Apr 7, 2023

The issue has been encountered on two separate PRs.

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=231297
Build error leg or test failing: Hybrid.WASM.Tests.WorkItemExecution
Pull request: #79169

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "(NETCORE_ENGINEERING_TELEMETRY=Test) Work item Hybrid.WASM.Tests in job",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}

Report

Build Definition Step Name Console log Pull Request
234114 dotnet/runtime Send to Helix Log #84552
233539 dotnet/runtime Send to Helix Log #84552
233540 dotnet/runtime Send to Helix Log
233505 dotnet/runtime Send to Helix Log #84148
233492 dotnet/runtime Send to Helix Log #82773
233240 dotnet/runtime Send to Helix Log #84148
233074 dotnet/runtime Send to Helix Log
233000 dotnet/runtime Send to Helix Log #82973
232973 dotnet/runtime Send to Helix Log #84552
232933 dotnet/runtime Send to Helix Log
232836 dotnet/runtime Send to Helix Log #82973
232774 dotnet/runtime Send to Helix Log #84318
232731 dotnet/runtime Send to Helix Log
232568 dotnet/runtime Send to Helix Log #82973
232561 dotnet/runtime Send to Helix Log
232430 dotnet/runtime Send to Helix Log #79169
232429 dotnet/runtime Send to Helix Log #79169
232401 dotnet/runtime Send to Helix Log
232375 dotnet/runtime Send to Helix Log #83151
232270 dotnet/runtime Send to Helix Log #84148
231952 dotnet/runtime Send to Helix Log
231848 dotnet/runtime Send to Helix Log #82773
231601 dotnet/runtime Send to Helix Log #83151
231490 dotnet/runtime Send to Helix Log #84330
231297 dotnet/runtime Send to Helix Log #79169
231259 dotnet/runtime Send to Helix Log
231230 dotnet/runtime Send to Helix Log #83151
230666 dotnet/runtime Send to Helix Log
230845 dotnet/runtime Send to Helix Log #84453
230873 dotnet/runtime Send to Helix Log #82773
230424 dotnet/runtime Send to Helix Log
230266 dotnet/runtime Send to Helix Log #79169
230264 dotnet/runtime Send to Helix Log #79169
229837 dotnet/runtime Send to Helix Log #79169

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
6 34 34
@kotlarmilos kotlarmilos added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Apr 7, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 7, 2023
@ghost
Copy link

ghost commented Apr 7, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=231297
Build error leg or test failing: Hybrid.WASM.Tests.WorkItemExecution
Pull request: #79169

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "Hybrid.WASM.Tests : interp_to_native_trampoline",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}
Author: kotlarmilos
Assignees: -
Labels:

blocking-clean-ci, area-Infrastructure-mono, Known Build Error

Milestone: -

@kotlarmilos kotlarmilos self-assigned this Apr 7, 2023
@kotlarmilos kotlarmilos removed the untriaged New issue has not been triaged by the area owner label Apr 7, 2023
@kotlarmilos
Copy link
Member Author

Interpreter on iOS and tvOS simulators can't find GlobalizationNative_GetLocaleInfoStringNative because it is conditionally emitted.

#if defined(TARGET_OSX) || defined(TARGET_MACCATALYST) || defined(TARGET_IOS) || defined(TARGET_TVOS)
const char* GlobalizationNative_GetLocaleNameNative(const char* localeName)
{
NSString *locName = [NSString stringWithFormat:@"%s", localeName];
NSLocale *currentLocale = [[NSLocale alloc] initWithLocaleIdentifier:locName];
const char* value = [currentLocale.localeIdentifier UTF8String];
return strdup(value);
}
const char* GlobalizationNative_GetLocaleInfoStringNative(const char* localeName, LocaleStringData localeStringData)
{
const char* value;
NSString *locName = [NSString stringWithFormat:@"%s", localeName];
NSLocale *currentLocale = [[NSLocale alloc] initWithLocaleIdentifier:locName];
NSNumberFormatter *numberFormatter = [[NSNumberFormatter alloc] init];
numberFormatter.locale = currentLocale;
NSDateFormatter* dateFormatter = [[NSDateFormatter alloc] init];
[dateFormatter setLocale:currentLocale];
NSLocale *gbLocale = [[NSLocale alloc] initWithLocaleIdentifier:@"en_GB"];

@ilonatommy @mkhamoyan are there simulator specific targets that could be used? If not, the test could be disabled on the simulators.

@SamMonoRT SamMonoRT removed the Known Build Error Use this to report build issues in the .NET Helix tab label Apr 10, 2023
@SamMonoRT SamMonoRT added this to the 8.0.0 milestone Apr 10, 2023
@mkhamoyan
Copy link
Member

mkhamoyan commented Apr 11, 2023

Interpreter on iOS and tvOS simulators can't find GlobalizationNative_GetLocaleInfoStringNative because it is conditionally emitted.

#if defined(TARGET_OSX) || defined(TARGET_MACCATALYST) || defined(TARGET_IOS) || defined(TARGET_TVOS)
const char* GlobalizationNative_GetLocaleNameNative(const char* localeName)
{
NSString *locName = [NSString stringWithFormat:@"%s", localeName];
NSLocale *currentLocale = [[NSLocale alloc] initWithLocaleIdentifier:locName];
const char* value = [currentLocale.localeIdentifier UTF8String];
return strdup(value);
}
const char* GlobalizationNative_GetLocaleInfoStringNative(const char* localeName, LocaleStringData localeStringData)
{
const char* value;
NSString *locName = [NSString stringWithFormat:@"%s", localeName];
NSLocale *currentLocale = [[NSLocale alloc] initWithLocaleIdentifier:locName];
NSNumberFormatter *numberFormatter = [[NSNumberFormatter alloc] init];
numberFormatter.locale = currentLocale;
NSDateFormatter* dateFormatter = [[NSDateFormatter alloc] init];
[dateFormatter setLocale:currentLocale];
NSLocale *gbLocale = [[NSLocale alloc] initWithLocaleIdentifier:@"en_GB"];

@ilonatommy @mkhamoyan are there simulator specific targets that could be used? If not, the test could be disabled on the simulators.

Looks like during wasm tests it also tries to run on ios/tvos platforms. @ilonatommy We need to run these tests only for browser/wasi platforms https://github.com/dotnet/runtime/blob/main/src/libraries/System.Globalization/tests/Hybrid/Hybrid.WASM.Tests.csproj , like is done for hybrid ios tests https://github.com/dotnet/runtime/blob/main/src/libraries/System.Globalization/tests/Hybrid/Hybrid.IOS.Tests.csproj

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 11, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-mono blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants