Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64: Add back the annotation in JitDisasm with the local var (+offset) #84504

Closed
kunalspathak opened this issue Apr 7, 2023 · 1 comment · Fixed by #85671
Closed

Arm64: Add back the annotation in JitDisasm with the local var (+offset) #84504

kunalspathak opened this issue Apr 7, 2023 · 1 comment · Fixed by #85671
Assignees
@kunalspathak
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
8.0.0

Comments

@kunalspathak
Copy link
Member

In #84399, we optimized pair of loads into ldp but with that stopped tracking the local var offset in the ldp's instrDesc. As a result, in JitDisasm, we will not see the offsets or the variable information next to these instructions. Likewise for stores. Below is the difference we can see:

image

Add back this functionality in non-release builds.
@kunalspathak kunalspathak added this to the 8.0.0 milestone Apr 7, 2023
@kunalspathak kunalspathak self-assigned this Apr 7, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 7, 2023
@kunalspathak kunalspathak mentioned this issue Apr 7, 2023
Merged
@ghost
Copy link

ghost commented Apr 7, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

In #84399, we optimized pair of loads into ldp but with that stopped tracking the local var offset in the ldp's instrDesc. As a result, in JitDisasm, we will not see the offsets or the variable information next to these instructions. Likewise for stores. Below is the difference we can see:

image

Add back this functionality in non-release builds.

Author: kunalspathak
Assignees: kunalspathak
Labels:

area-CodeGen-coreclr
Milestone: 8.0.0

@kunalspathak kunalspathak mentioned this issue Apr 21, 2023
Merged
@kunalspathak kunalspathak mentioned this issue May 2, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 2, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Arm64: Add back the annotation in JitDisasm with the local var (+offset) kunalspathak/runtime
1 participant
@kunalspathak