Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider consolidating methods in the EventPipe OS PAL in to a shared file #87069

Open
LakshanF opened this issue Jun 2, 2023 · 2 comments
Open

Comments

@LakshanF
Copy link
Member

LakshanF commented Jun 2, 2023

The 3 runtimes - Mono, CoreCLR, NativeAOT - have separate code that should be moved to a shared space:

  • ipc_get_process_id_disambiguation_key: Currently, very similar code is shared by the three runtimes separately (mono, CoreCLR, NativeAOT) for ipc_get_process_id_disambiguation_key. We should move the code to the common code so as not to duplicate.
  • ep_rt_os_environment_get_utf16
  • Emulate PAL like functions for _tcslen (strlen) / _tcsrchr (wcsrchr, strrchr) to make the code easier to read in ep_rt_aot_entrypoint_assembly_name_get_utf8
  • Consider replacing with a new PalInterlockedIncrement64, PalInterlockedDecrement64 for the current Exchange calls on ep_rt_aot_atomic_inc_int64_t and ep_rt_aot_atomic_dec_int64_t
  • EventPipeActivityControlCode enum (ActivityControlCode in CoreCLR and NativeAOT)
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 2, 2023
@LakshanF LakshanF self-assigned this Jun 2, 2023
@LakshanF LakshanF added EventPipe area-NativeAOT-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 2, 2023
@LakshanF LakshanF added this to the 8.0.0 milestone Jun 2, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 2, 2023
@ghost
Copy link

ghost commented Jun 2, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently, very similar code is shared by the three runtimes separately (mono, CoreCLR, NativeAOT) for ipc_get_process_id_disambiguation_key. We should move the code to the common code so as not to duplicate.

Author: LakshanF
Assignees: LakshanF
Labels:

EventPipe, area-NativeAOT-coreclr, needs-area-label

Milestone: -

@jkotas
Copy link
Member

jkotas commented Jun 2, 2023

Currently, very similar code is shared by the three runtimes separately (mono, CoreCLR, NativeAOT) for ipc_get_process_id_disambiguation_key.

ipc_get_process_id_disambiguation_key is just one of many examples. All methods in the eventpipe OS PAL layer should be in shared file.

@LakshanF LakshanF changed the title Consider consolidating EventPipe ipc_get_process_id_disambiguation_key Consider consolidating methods in the EventPipe OS PAL in to a shared file Jul 6, 2023
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Jul 27, 2023
@LakshanF LakshanF modified the milestones: 8.0.0, 9.0.0 Jul 31, 2023
@agocke agocke modified the milestones: 9.0.0, 10.0.0 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants