Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EventPipe adapter from NativeAOT implementation #88262

Closed
LakshanF opened this issue Jun 30, 2023 · 2 comments
Closed

Remove EventPipe adapter from NativeAOT implementation #88262

LakshanF opened this issue Jun 30, 2023 · 2 comments
Assignees
@LakshanF
Labels
area-NativeAOT-coreclr
Milestone
8.0.0

Comments

@LakshanF
Copy link
Member

NativeAOT started with the CoreCLR implementation and uses the CoreCLR adapter. However, as these two (here and here) comments indicate, its better to do away with the indirection similar to how mono implements this. NativeAOT does not support Profiler support and does not need the additional complexity. Its not a direct mono implementation since CoreCLR takes advantage of the C++ features (use of destructors instead of *_fini pattern mono's C use.
@LakshanF LakshanF added this to the 8.0.0 milestone Jun 30, 2023
@LakshanF LakshanF self-assigned this Jun 30, 2023
@ghost
Copy link

ghost commented Jun 30, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

NativeAOT started with the CoreCLR implementation and uses the CoreCLR adapter. However, as these two (here and here) comments indicate, its better to do away with the indirection similar to how mono implements this. NativeAOT does not support Profiler support and does not need the additional complexity. Its not a direct mono implementation since CoreCLR takes advantage of the C++ features (use of destructors instead of *_fini pattern mono's C use.

Author: LakshanF
Assignees: LakshanF
Labels:

area-NativeAOT-coreclr
Milestone: 8.0.0

@LakshanF LakshanF mentioned this issue Jun 30, 2023
Merged
@LakshanF
Copy link
Member Author

Done with #88941

@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LakshanF LakshanF

Labels
area-NativeAOT-coreclr
Projects
AppModel
Archived in project
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@LakshanF