Incorrect value in FirstDayOfWeek test #93354

ilonatommy · 2023-10-11T17:01:03Z

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=432866
Build error leg or test failing: System.Globalization.Tests.DateTimeFormatInfoFirstDayOfWeek.FirstDayOfWeek
Pull request: #93224

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "Expected: Monday",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

info: Expected: Monday
info: Actual:   Sunday

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=432866
Error message validated: Expected: Monday
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 10/11/2023 5:08:28 PM UTC

Report

Build	Definition	Test	Pull Request
441921	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93368
440108	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93409
440065	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93565
439944	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93223
440049	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93564
440042	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93563
439988	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93558
439923	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93553
439839	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93178
439911	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93556
439914	dotnet/runtime	WasmTestOnNodeJS-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93556
439871	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#90436
439461	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93545
439861	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#92550
439825	dotnet/runtime	WasmTestOnBrowser-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93548
439488	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93547
439718	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#90771
439417	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93542
439521	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93280
439482	dotnet/runtime	WasmTestOnBrowser-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93223
439467	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93546
439458	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93472
437781	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93380
437294	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93440
435814	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93380
435815	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93380
435488	dotnet/runtime	normal-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93182
432866	dotnet/runtime	WasmTestOnBrowser-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93224

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
1	27	28

The text was updated successfully, but these errors were encountered:

ghost · 2023-10-11T17:18:17Z

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=432866
Build error leg or test failing: System.Globalization.Tests.DateTimeFormatInfoFirstDayOfWeek.FirstDayOfWeek
Pull request: #93224

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "Expected: Monday",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

info: Expected: Monday
info: Actual:   Sunday

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=432866
Error message validated: Expected: Monday
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 10/11/2023 5:08:28 PM UTC

Author:	ilonatommy
Assignees:	-
Labels:	`area-System.Globalization`, `blocking-clean-ci`, `untriaged`, `Known Build Error`, `needs-area-label`
Milestone:	-

ghost · 2023-10-11T19:02:12Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=432866
Build error leg or test failing: System.Globalization.Tests.DateTimeFormatInfoFirstDayOfWeek.FirstDayOfWeek
Pull request: #93224

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "Expected: Monday",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

info: Expected: Monday
info: Actual:   Sunday

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=432866
Error message validated: Expected: Monday
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 10/11/2023 5:08:28 PM UTC

Report

Build	Definition	Test	Pull Request
432866	dotnet/runtime	WasmTestOnBrowser-System.Globalization.Hybrid.WASM.Tests.WorkItemExecution	#93224

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	1	1

Author:	ilonatommy
Assignees:	-
Labels:	`arch-wasm`, `area-System.Globalization`, `blocking-clean-ci`, `untriaged`, `Known Build Error`
Milestone:	-

SmartmanApps · 2023-10-11T20:20:24Z

ilonatommy · 2023-10-12T08:49:06Z

@SmartmanApps thank you for trying to help. However, it is not that simple. This failure is in test that checks all locales available on WASM (~200) and makes sure native JS code returns the correct day of the week for them. I wish all locales had the same response to new CultureInfo(locale_code_string).DateTimeFormat.FirstDayOfWeek but they do not. If you re interested, you can see

runtime/src/libraries/System.Globalization/tests/DateTimeFormatInfo/DateTimeFormatInfoFirstDayOfWeek.cs

Line 20 in 8c21ead

{

to have a better understanding what values we expect from each locales. I can't reproduce the error to detect which locale is the offender, so I created a PR that will surface this information in the error message.
Edit: it fails on "fr-FR" where ICU and ISO standard is Monday.

lewing · 2023-10-16T17:53:59Z

Is this happening consistently or just occasionally?

radical · 2023-10-16T20:31:52Z

Is this happening consistently or just occasionally?

Oddly, I don't see any failures in rolling builds in the last 2 weeks!

radical · 2023-10-16T20:32:42Z

And the tests ran on the last PR that bumped the chrome version, where they didn't fail either.

ilonatommy · 2023-10-17T07:17:05Z

Is this happening consistently or just occasionally?

Occasionally but quite often. It never fails for me when I try to reproduce. Pavel has an idea that it might depend on location of data center where CI tests are run, so next step would be to try to repro changing TZ on the machine to see if I find the one that fails.
Edit: hypothesis with host's TZ effect is not true. I reproduced for VM in East US but only once, a re-run did not fail.

ilonatommy added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Oct 11, 2023

dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 11, 2023

ghost added the untriaged New issue has not been triaged by the area owner label Oct 11, 2023

radical added the area-System.Globalization label Oct 11, 2023

vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 11, 2023

tarekgh added the arch-wasm WebAssembly architecture label Oct 11, 2023

ilonatommy mentioned this issue Oct 12, 2023

[browser][HybridGlobalization] Improve logging on FirstDayOfWeek failures #93380

Merged

ilonatommy self-assigned this Oct 12, 2023

lewing mentioned this issue Oct 16, 2023

[wasm] Fix Vector128 SIMD fmin and fmax #93556

Merged

radical removed the untriaged New issue has not been triaged by the area owner label Oct 16, 2023

ilonatommy mentioned this issue Oct 17, 2023

[browser][HybridGlobalization] Fix incorrect value in FirstDayOfWeek test #93595

Merged

ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 17, 2023

ilonatommy closed this as completed in #93595 Oct 18, 2023

ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 18, 2023

ghost locked as resolved and limited conversation to collaborators Nov 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Incorrect value in FirstDayOfWeek test #93354

Incorrect value in FirstDayOfWeek test #93354

ilonatommy commented Oct 11, 2023 •

edited by build-analysis bot

Loading

ghost commented Oct 11, 2023

Build Information

Error Message

Known issue validation

ghost commented Oct 11, 2023

Build Information

Error Message

Known issue validation

Report

Summary

SmartmanApps commented Oct 11, 2023

ilonatommy commented Oct 12, 2023 •

edited

Loading

lewing commented Oct 16, 2023 •

edited

Loading

radical commented Oct 16, 2023

radical commented Oct 16, 2023

ilonatommy commented Oct 17, 2023 •

edited

Loading

Incorrect value in FirstDayOfWeek test #93354

Incorrect value in FirstDayOfWeek test #93354

Comments

ilonatommy commented Oct 11, 2023 • edited by build-analysis bot Loading

Build Information

Error Message

Known issue validation

Report

Summary

ghost commented Oct 11, 2023

Build Information

Error Message

Known issue validation

ghost commented Oct 11, 2023

Build Information

Error Message

Known issue validation

Report

Summary

SmartmanApps commented Oct 11, 2023

ilonatommy commented Oct 12, 2023 • edited Loading

lewing commented Oct 16, 2023 • edited Loading

radical commented Oct 16, 2023

radical commented Oct 16, 2023

ilonatommy commented Oct 17, 2023 • edited Loading

ilonatommy commented Oct 11, 2023 •

edited by build-analysis bot

Loading

ilonatommy commented Oct 12, 2023 •

edited

Loading

lewing commented Oct 16, 2023 •

edited

Loading

ilonatommy commented Oct 17, 2023 •

edited

Loading