Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does ARM now supported by ObjWriter? #1526

Closed
kant2002 opened this issue Sep 7, 2021 · 5 comments
Closed

Does ARM now supported by ObjWriter? #1526

kant2002 opened this issue Sep 7, 2021 · 5 comments

Comments

@kant2002
Copy link
Contributor

kant2002 commented Sep 7, 2021

I'm interested technically, given that ARM is building now, that's mean that ObjWriter published to Nuget? And technically ILC can build ARM without specific problems.

@kant2002
Copy link
Contributor Author

kant2002 commented Sep 7, 2021

I probably should formulate my questions more clearly.

Will dotnet publish -r linux-arm /p:DisableUnsupportedError=true works without local build If I change

<ILCompilerVersion>7.0.0-alpha.1.21455.2</ILCompilerVersion>

Or there some other work needed?

@jkotas
Copy link
Member

jkotas commented Sep 7, 2021

Yes, it should. Does it work for you?

@kant2002
Copy link
Contributor Author

kant2002 commented Sep 7, 2021

No, right now it does not work if I use what's in Nuget

pi@raspberrypi:~/runtimelab/samples/HelloWorld $ ../../.dotnet/dotnet publish -c Release -r linux-arm --packages pkg /p:DisableUnsupportedError=true
Microsoft (R) Build Engine version 17.0.0-preview-21427-02+414393fc1 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  Restored /home/pi/runtimelab/samples/HelloWorld/HelloWorld.csproj (in 5.02 min).
  You are using a preview version of .NET. See: https://aka.ms/dotnet-core-preview
/home/pi/runtimelab/.dotnet/sdk/6.0.100-rc.1.21430.12/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(1105,5): warning NETSDK1179: One of '--self-contained' or '--no-self-contained' options are required when '--runtime' is used. [/home/pi/runtimelab/samples/HelloWorld/HelloWorld.csproj]
  HelloWorld -> /home/pi/runtimelab/samples/HelloWorld/bin/Release/net6.0/linux-arm/HelloWorld.dll
/home/pi/runtimelab/samples/HelloWorld/pkg/microsoft.dotnet.ilcompiler/7.0.0-alpha.1.21457.2/build/Microsoft.NETCore.Native.Publish.targets(75,5): error : The PrivateSdkAssemblies ItemGroup is required for _ComputeAssembliesToCompileToNative [/home/pi/runtimelab/samples/HelloWorld/HelloWorld.csproj]
pi@raspberrypi:~/runtimelab/samples/HelloWorld $ ls pkg/
microsoft.aspnetcore.app.runtime.linux-arm  microsoft.dotnet.ilcompiler  microsoft.netcore.app.runtime.linux-arm

I see missing runtime.linux-arm.microsoft.dotnet.ilcompiler.

Will check with local build in near future.

@jkotas
Copy link
Member

jkotas commented Sep 7, 2021

You may need to fix src\installer\pkg\projects\Microsoft.DotNet.ILCompiler\ILCompilerRIDs.props

@kant2002
Copy link
Contributor Author

kant2002 commented Sep 8, 2021

Works now. In a sense that it produce binary. Obviously I have to fix #1517 to call that "works"

@kant2002 kant2002 closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants