Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate a more helpful error message if Compile (or other implicit items) are specified multiple times #600

Closed
dsplaisted opened this issue Jan 7, 2017 · 3 comments
Closed

Generate a more helpful error message if Compile (or other implicit items) are specified multiple times #600

dsplaisted opened this issue Jan 7, 2017 · 3 comments
Assignees
@dsplaisted
Labels
Bug Urgency-Soon
Milestone
1.0 RC3

Comments

@dsplaisted
Copy link
Member

If the implicit items are enabled and also explicitly added to the project file, the compiler will generate an error saying that the source file was specified multiple times. We should detect this situation earlier and provide an error message which tells how to disable the implicit items if desired.
@srivatsn srivatsn added the Bug label Jan 7, 2017
@srivatsn srivatsn added this to the 1.0 RC3 milestone Jan 7, 2017
@srivatsn
Copy link
Contributor

srivatsn commented Jan 7, 2017

We should do something here for RC3 or else all existing projects are going to run into this when they upgrade to RC3.

@eerhardt eerhardt mentioned this issue Jan 9, 2017
Closed
@dsplaisted
Copy link
Member Author

This should also handle duplicate PackageReference items.

This was referenced Jan 10, 2017
Closed
Merged
@srivatsn
Copy link
Contributor

Fixed by #624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsplaisted dsplaisted

Labels
Bug Urgency-Soon
Projects
None yet
Milestone
1.0 RC3
Development

No branches or pull requests
2 participants
@srivatsn @dsplaisted