From 53a017579875dc45232c530685d656932426322f Mon Sep 17 00:00:00 2001 From: Daniel Plaisted Date: Fri, 14 Apr 2017 17:39:03 -0700 Subject: [PATCH 01/11] Add option to not include "main project" info in deps file --- .../GivenADependencyContextBuilder.cs | 3 +- .../DependencyContextBuilder.cs | 37 +++++++++++++++---- .../GenerateDepsFile.cs | 23 ++++++++---- .../build/Microsoft.NET.Publish.targets | 2 + .../build/Microsoft.NET.Sdk.targets | 5 +++ 5 files changed, 55 insertions(+), 15 deletions(-) diff --git a/src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenADependencyContextBuilder.cs b/src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenADependencyContextBuilder.cs index e6860b12e721..dd0f869bbc9a 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenADependencyContextBuilder.cs +++ b/src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenADependencyContextBuilder.cs @@ -52,7 +52,8 @@ public void ItBuildsDependencyContextsFromProjectLockFiles( Constants.DefaultPlatformLibrary, isSelfContained: !string.IsNullOrEmpty(runtime)); - DependencyContext dependencyContext = new DependencyContextBuilder(mainProject, projectContext) + DependencyContext dependencyContext = new DependencyContextBuilder(projectContext) + .WithMainProject(mainProject) .WithDirectReferences(directReferences) .WithCompilationOptions(compilationOptions) .Build(); diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs b/src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs index 58f5c0e1980f..257178a8eb00 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs +++ b/src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs @@ -18,7 +18,7 @@ namespace Microsoft.NET.Build.Tasks internal class DependencyContextBuilder { private readonly VersionFolderPathResolver _versionFolderPathResolver; - private readonly SingleProjectInfo _mainProjectInfo; + private SingleProjectInfo _mainProjectInfo; private readonly ProjectContext _projectContext; private IEnumerable _frameworkReferences; private IEnumerable _directReferences; @@ -28,15 +28,20 @@ internal class DependencyContextBuilder private string _referenceAssembliesPath; private Dictionary _filteredPackages; - public DependencyContextBuilder(SingleProjectInfo mainProjectInfo, ProjectContext projectContext) + public DependencyContextBuilder(ProjectContext projectContext) { - _mainProjectInfo = mainProjectInfo; _projectContext = projectContext; // This resolver is only used for building file names, so that base path is not required. _versionFolderPathResolver = new VersionFolderPathResolver(rootPath: null); } + public DependencyContextBuilder WithMainProject(SingleProjectInfo mainProjectInfo) + { + _mainProjectInfo = mainProjectInfo; + return this; + } + public DependencyContextBuilder WithFrameworkReferences(IEnumerable frameworkReferences) { // note: Framework libraries only export compile-time stuff @@ -106,7 +111,7 @@ public DependencyContext Build() _projectContext, dependencyLookup); IEnumerable runtimeLibraries = - new[] { projectRuntimeLibrary } + (projectRuntimeLibrary == null ? Enumerable.Empty() : new[] { projectRuntimeLibrary }) .Concat(GetLibraries(runtimeExports, libraryLookup, dependencyLookup, runtime: true).Cast()) .Concat(GetDirectReferenceRuntimeLibraries()); @@ -118,7 +123,7 @@ public DependencyContext Build() _projectContext, dependencyLookup); compilationLibraries = - new[] { projectCompilationLibrary } + (projectCompilationLibrary == null ? Enumerable.Empty() : new[] { projectCompilationLibrary }) .Concat(GetFrameworkLibraries()) .Concat(GetLibraries(compilationExports, libraryLookup, dependencyLookup, runtime: false).Cast()) .Concat(GetDirectReferenceCompilationLibraries()); @@ -233,6 +238,11 @@ private RuntimeLibrary GetProjectRuntimeLibrary( ProjectContext projectContext, Dictionary dependencyLookup) { + if (projectInfo == null) + { + return null; + } + RuntimeAssetGroup[] runtimeAssemblyGroups = new[] { new RuntimeAssetGroup(string.Empty, projectInfo.OutputName) }; List dependencies = GetProjectDependencies(projectContext, dependencyLookup); @@ -254,6 +264,11 @@ private CompilationLibrary GetProjectCompilationLibrary( ProjectContext projectContext, Dictionary dependencyLookup) { + if (projectInfo == null) + { + return null; + } + List dependencies = GetProjectDependencies(projectContext, dependencyLookup); return new CompilationLibrary( @@ -523,8 +538,16 @@ private SingleProjectInfo GetProjectInfo(LockFileLibrary library) throw new BuildErrorException(Strings.CannotFindProjectInfo, library.Name); } - string mainProjectDirectory = Path.GetDirectoryName(_mainProjectInfo.ProjectPath); - string fullProjectPath = Path.GetFullPath(Path.Combine(mainProjectDirectory, projectPath)); + string fullProjectPath; + if (_mainProjectInfo != null) + { + string mainProjectDirectory = Path.GetDirectoryName(_mainProjectInfo.ProjectPath); + fullProjectPath = Path.GetFullPath(Path.Combine(mainProjectDirectory, projectPath)); + } + else + { + fullProjectPath = Path.GetFullPath(projectPath); + } SingleProjectInfo referenceProjectInfo = null; if (_referenceProjectInfos?.TryGetValue(fullProjectPath, out referenceProjectInfo) != true || diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/GenerateDepsFile.cs b/src/Tasks/Microsoft.NET.Build.Tasks/GenerateDepsFile.cs index 9db941e80a6a..da1529bf889a 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/GenerateDepsFile.cs +++ b/src/Tasks/Microsoft.NET.Build.Tasks/GenerateDepsFile.cs @@ -49,6 +49,9 @@ public class GenerateDepsFile : TaskBase [Required] public ITaskItem[] AssemblySatelliteAssemblies { get; set; } + [Required] + public bool IncludeMainProject { get; set; } + [Required] public ITaskItem[] ReferencePaths { get; set; } @@ -116,12 +119,17 @@ protected override void ExecuteCore() LockFile lockFile = new LockFileCache(BuildEngine4).GetLockFile(AssetsFilePath); CompilationOptions compilationOptions = CompilationOptionsConverter.ConvertFrom(CompilerOptions); - SingleProjectInfo mainProject = SingleProjectInfo.Create( - ProjectPath, - AssemblyName, - AssemblyExtension, - AssemblyVersion, - AssemblySatelliteAssemblies); + SingleProjectInfo mainProject = null; + + if (IncludeMainProject) + { + mainProject = SingleProjectInfo.Create( + ProjectPath, + AssemblyName, + AssemblyExtension, + AssemblyVersion, + AssemblySatelliteAssemblies); + } IEnumerable frameworkReferences = ReferenceInfo.CreateFrameworkReferenceInfos(ReferencePaths); @@ -141,7 +149,8 @@ protected override void ExecuteCore() PlatformLibraryName, IsSelfContained); - DependencyContext dependencyContext = new DependencyContextBuilder(mainProject, projectContext) + DependencyContext dependencyContext = new DependencyContextBuilder(projectContext) + .WithMainProject(mainProject) .WithFrameworkReferences(frameworkReferences) .WithDirectReferences(directReferences) .WithReferenceProjectInfos(referenceProjects) diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Publish.targets b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Publish.targets index 7eb92b5e6378..7ef0be1ed896 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Publish.targets +++ b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Publish.targets @@ -468,6 +468,7 @@ Copyright (c) .NET Foundation. All rights reserved. $(PublishDir)$(ProjectDepsFileName) + true + + true + + + + + + + + + netcoreapp$(BundledNETCoreAppTargetFrameworkVersion) + + $([System.IO.Path]::GetDirectoryName($(ProjectAssetsFile))) + $(ToolFolder)\$(ToolName).deps.json + + Exe + false + + + + + + + + + From 645556befcca8960e44b7336923e090586e4fdcc Mon Sep 17 00:00:00 2001 From: Daniel Plaisted Date: Mon, 17 Apr 2017 22:12:52 -0700 Subject: [PATCH 03/11] Set the TFM used to restore .NET CLI tools to match the version of .NET Core bundled in the CLI Also include GenerateDeps.proj in tasks project --- .../Microsoft.NET.Build.Tasks.csproj | 3 +++ .../build/Microsoft.NET.Sdk.targets | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj b/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj index 131c60ecb85f..6355c740dc98 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj +++ b/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj @@ -188,6 +188,9 @@ Strings.resx + + + diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.targets b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.targets index bf27be9de083..db5cbac2332a 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.targets +++ b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.targets @@ -62,6 +62,11 @@ Copyright (c) .NET Foundation. All rights reserved. <_DotNetHostPolicyLibraryName>$(_NativeLibraryPrefix)hostpolicy$(_NativeLibraryExtension) <_DotNetHostFxrLibraryName>$(_NativeLibraryPrefix)hostfxr$(_NativeLibraryExtension) + + + + netcoreapp$(BundledNETCoreAppTargetFrameworkVersion) + From 0478a81a93feb39e49401af58dbd4d8316a5a995 Mon Sep 17 00:00:00 2001 From: Daniel Plaisted Date: Tue, 18 Apr 2017 22:17:09 -0700 Subject: [PATCH 04/11] Include GenerateDeps.proj in SDK layout, and set property for .NET CLI to use to get the path to it in the SDK --- .../Microsoft.NET.Build.Tasks.csproj | 4 +++- .../build/GenerateDeps/GenerateDeps.proj | 2 +- .../Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.props | 5 +++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj b/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj index 6355c740dc98..9f0a4b2eb4fa 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj +++ b/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj @@ -189,7 +189,9 @@ - + + PreserveNewest + diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/build/GenerateDeps/GenerateDeps.proj b/src/Tasks/Microsoft.NET.Build.Tasks/build/GenerateDeps/GenerateDeps.proj index d7e237077338..583c9c0aea26 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/build/GenerateDeps/GenerateDeps.proj +++ b/src/Tasks/Microsoft.NET.Build.Tasks/build/GenerateDeps/GenerateDeps.proj @@ -29,7 +29,7 @@ Copyright (c) .NET Foundation. All rights reserved. netcoreapp$(BundledNETCoreAppTargetFrameworkVersion) $([System.IO.Path]::GetDirectoryName($(ProjectAssetsFile))) - $(ToolFolder)\$(ToolName).deps.json + $(ToolFolder)\$(ToolName).deps.json Exe false diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.props b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.props index 8333c8e1f879..fe7f2001550f 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.props +++ b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.props @@ -103,6 +103,11 @@ Copyright (c) .NET Foundation. All rights reserved. false false + + + + $(MSBuildThisFileDirectory)GenerateDeps\GenerateDeps.proj + From 9e7d1b805758c817bc9c33c4bf82cd5aa9d78150 Mon Sep 17 00:00:00 2001 From: Daniel Plaisted Date: Mon, 24 Apr 2017 16:32:19 -0700 Subject: [PATCH 05/11] Set DotnetCliToolTargetFramework in crosstargeting builds --- .../build/Microsoft.NET.Sdk.Common.targets | 4 ++++ .../build/Microsoft.NET.Sdk.targets | 5 ----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.Common.targets b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.Common.targets index 1cdc34e1eca1..fe9b99e822ea 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.Common.targets +++ b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.Common.targets @@ -28,6 +28,10 @@ Copyright (c) .NET Foundation. All rights reserved. Microsoft.NETCore.App;NETStandard.Library + + + netcoreapp$(BundledNETCoreAppTargetFrameworkVersion) + diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.targets b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.targets index db5cbac2332a..01d9ee7920a7 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.targets +++ b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Sdk.targets @@ -63,11 +63,6 @@ Copyright (c) .NET Foundation. All rights reserved. <_DotNetHostFxrLibraryName>$(_NativeLibraryPrefix)hostfxr$(_NativeLibraryExtension) - - - netcoreapp$(BundledNETCoreAppTargetFrameworkVersion) - - $(CoreBuildDependsOn); From 4d1ab8cf5d805493430baff69609efb02a976691 Mon Sep 17 00:00:00 2001 From: Daniel Plaisted Date: Thu, 27 Apr 2017 00:38:12 -0700 Subject: [PATCH 06/11] Apply code review feedback --- .../GivenADependencyContextBuilder.cs | 3 +- .../DependencyContextBuilder.cs | 74 +++++++++---------- .../GenerateDepsFile.cs | 13 +--- .../build/GenerateDeps/GenerateDeps.proj | 2 - .../build/Microsoft.NET.Publish.targets | 1 - .../build/Microsoft.NET.Sdk.targets | 5 +- 6 files changed, 39 insertions(+), 59 deletions(-) diff --git a/src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenADependencyContextBuilder.cs b/src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenADependencyContextBuilder.cs index dd0f869bbc9a..e6860b12e721 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenADependencyContextBuilder.cs +++ b/src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenADependencyContextBuilder.cs @@ -52,8 +52,7 @@ public void ItBuildsDependencyContextsFromProjectLockFiles( Constants.DefaultPlatformLibrary, isSelfContained: !string.IsNullOrEmpty(runtime)); - DependencyContext dependencyContext = new DependencyContextBuilder(projectContext) - .WithMainProject(mainProject) + DependencyContext dependencyContext = new DependencyContextBuilder(mainProject, projectContext) .WithDirectReferences(directReferences) .WithCompilationOptions(compilationOptions) .Build(); diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs b/src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs index 257178a8eb00..74e9659d3a3b 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs +++ b/src/Tasks/Microsoft.NET.Build.Tasks/DependencyContextBuilder.cs @@ -18,7 +18,7 @@ namespace Microsoft.NET.Build.Tasks internal class DependencyContextBuilder { private readonly VersionFolderPathResolver _versionFolderPathResolver; - private SingleProjectInfo _mainProjectInfo; + private readonly SingleProjectInfo _mainProjectInfo; private readonly ProjectContext _projectContext; private IEnumerable _frameworkReferences; private IEnumerable _directReferences; @@ -27,18 +27,20 @@ internal class DependencyContextBuilder private CompilationOptions _compilationOptions; private string _referenceAssembliesPath; private Dictionary _filteredPackages; + private bool _includeMainProjectInDepsFile = true; - public DependencyContextBuilder(ProjectContext projectContext) + public DependencyContextBuilder(SingleProjectInfo mainProjectInfo, ProjectContext projectContext) { + _mainProjectInfo = mainProjectInfo; _projectContext = projectContext; // This resolver is only used for building file names, so that base path is not required. _versionFolderPathResolver = new VersionFolderPathResolver(rootPath: null); } - public DependencyContextBuilder WithMainProject(SingleProjectInfo mainProjectInfo) + public DependencyContextBuilder WithMainProjectInDepsFile(bool includeMainProjectInDepsFile) { - _mainProjectInfo = mainProjectInfo; + _includeMainProjectInDepsFile = includeMainProjectInDepsFile; return this; } @@ -106,32 +108,40 @@ public DependencyContext Build() var runtimeSignature = GenerateRuntimeSignature(runtimeExports); - RuntimeLibrary projectRuntimeLibrary = GetProjectRuntimeLibrary( - _mainProjectInfo, - _projectContext, - dependencyLookup); - IEnumerable runtimeLibraries = - (projectRuntimeLibrary == null ? Enumerable.Empty() : new[] { projectRuntimeLibrary }) + IEnumerable runtimeLibraries = Enumerable.Empty(); + if (_includeMainProjectInDepsFile) + { + runtimeLibraries = runtimeLibraries.Concat(new[] + { + GetProjectRuntimeLibrary( + _mainProjectInfo, + _projectContext, + dependencyLookup) + }); + } + runtimeLibraries = runtimeLibraries .Concat(GetLibraries(runtimeExports, libraryLookup, dependencyLookup, runtime: true).Cast()) .Concat(GetDirectReferenceRuntimeLibraries()); - IEnumerable compilationLibraries; + IEnumerable compilationLibraries = Enumerable.Empty(); if (includeCompilationLibraries) { - CompilationLibrary projectCompilationLibrary = GetProjectCompilationLibrary( - _mainProjectInfo, - _projectContext, - dependencyLookup); - compilationLibraries = - (projectCompilationLibrary == null ? Enumerable.Empty() : new[] { projectCompilationLibrary }) + if (_includeMainProjectInDepsFile) + { + compilationLibraries = compilationLibraries.Concat(new[] + { + GetProjectCompilationLibrary( + _mainProjectInfo, + _projectContext, + dependencyLookup) + }); + } + + compilationLibraries = compilationLibraries .Concat(GetFrameworkLibraries()) .Concat(GetLibraries(compilationExports, libraryLookup, dependencyLookup, runtime: false).Cast()) .Concat(GetDirectReferenceCompilationLibraries()); } - else - { - compilationLibraries = Enumerable.Empty(); - } var targetInfo = new TargetInfo( _projectContext.LockFileTarget.TargetFramework.DotNetFrameworkName, @@ -238,11 +248,6 @@ private RuntimeLibrary GetProjectRuntimeLibrary( ProjectContext projectContext, Dictionary dependencyLookup) { - if (projectInfo == null) - { - return null; - } - RuntimeAssetGroup[] runtimeAssemblyGroups = new[] { new RuntimeAssetGroup(string.Empty, projectInfo.OutputName) }; List dependencies = GetProjectDependencies(projectContext, dependencyLookup); @@ -264,11 +269,6 @@ private CompilationLibrary GetProjectCompilationLibrary( ProjectContext projectContext, Dictionary dependencyLookup) { - if (projectInfo == null) - { - return null; - } - List dependencies = GetProjectDependencies(projectContext, dependencyLookup); return new CompilationLibrary( @@ -538,16 +538,8 @@ private SingleProjectInfo GetProjectInfo(LockFileLibrary library) throw new BuildErrorException(Strings.CannotFindProjectInfo, library.Name); } - string fullProjectPath; - if (_mainProjectInfo != null) - { - string mainProjectDirectory = Path.GetDirectoryName(_mainProjectInfo.ProjectPath); - fullProjectPath = Path.GetFullPath(Path.Combine(mainProjectDirectory, projectPath)); - } - else - { - fullProjectPath = Path.GetFullPath(projectPath); - } + string mainProjectDirectory = Path.GetDirectoryName(_mainProjectInfo.ProjectPath); + string fullProjectPath = Path.GetFullPath(Path.Combine(mainProjectDirectory, projectPath)); SingleProjectInfo referenceProjectInfo = null; if (_referenceProjectInfos?.TryGetValue(fullProjectPath, out referenceProjectInfo) != true || diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/GenerateDepsFile.cs b/src/Tasks/Microsoft.NET.Build.Tasks/GenerateDepsFile.cs index da1529bf889a..5d6d39a76290 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/GenerateDepsFile.cs +++ b/src/Tasks/Microsoft.NET.Build.Tasks/GenerateDepsFile.cs @@ -119,17 +119,12 @@ protected override void ExecuteCore() LockFile lockFile = new LockFileCache(BuildEngine4).GetLockFile(AssetsFilePath); CompilationOptions compilationOptions = CompilationOptionsConverter.ConvertFrom(CompilerOptions); - SingleProjectInfo mainProject = null; - - if (IncludeMainProject) - { - mainProject = SingleProjectInfo.Create( + SingleProjectInfo mainProject = SingleProjectInfo.Create( ProjectPath, AssemblyName, AssemblyExtension, AssemblyVersion, - AssemblySatelliteAssemblies); - } + AssemblySatelliteAssemblies); IEnumerable frameworkReferences = ReferenceInfo.CreateFrameworkReferenceInfos(ReferencePaths); @@ -149,8 +144,8 @@ protected override void ExecuteCore() PlatformLibraryName, IsSelfContained); - DependencyContext dependencyContext = new DependencyContextBuilder(projectContext) - .WithMainProject(mainProject) + DependencyContext dependencyContext = new DependencyContextBuilder(mainProject, projectContext) + .WithMainProjectInDepsFile(IncludeMainProject) .WithFrameworkReferences(frameworkReferences) .WithDirectReferences(directReferences) .WithReferenceProjectInfos(referenceProjects) diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/build/GenerateDeps/GenerateDeps.proj b/src/Tasks/Microsoft.NET.Build.Tasks/build/GenerateDeps/GenerateDeps.proj index 583c9c0aea26..9a6ba50b67f6 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/build/GenerateDeps/GenerateDeps.proj +++ b/src/Tasks/Microsoft.NET.Build.Tasks/build/GenerateDeps/GenerateDeps.proj @@ -26,8 +26,6 @@ Copyright (c) .NET Foundation. All rights reserved. Condition=" '$(AdditionalImport)' != '' And Exists($(AdditionalImport))" /> - netcoreapp$(BundledNETCoreAppTargetFrameworkVersion) - $([System.IO.Path]::GetDirectoryName($(ProjectAssetsFile))) $(ToolFolder)\$(ToolName).deps.json diff --git a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Publish.targets b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Publish.targets index 7ef0be1ed896..fa42fc1ae9ba 100644 --- a/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Publish.targets +++ b/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.Publish.targets @@ -468,7 +468,6 @@ Copyright (c) .NET Foundation. All rights reserved. $(PublishDir)$(ProjectDepsFileName) - true $(AssemblyName).runtimeconfig.json $(TargetDir)$(ProjectRuntimeConfigFileName) $(TargetDir)$(AssemblyName).runtimeconfig.dev.json + true @@ -86,10 +87,6 @@ Copyright (c) .NET Foundation. All rights reserved. Inputs="$(ProjectAssetsFile)" Outputs="$(ProjectDepsFilePath)"> - - true - -