Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ArPow] Add missing sourcebuild graph dependencies for installer #2239

Closed
MichaelSimons opened this issue Jun 17, 2021 · 4 comments
Closed

[ArPow] Add missing sourcebuild graph dependencies for installer #2239

MichaelSimons opened this issue Jun 17, 2021 · 4 comments
Labels
area-arcade Common Arcade source-build infra

Comments

@MichaelSimons
Copy link
Member

These dependencies are important for two main reasons.

  1. It determines the build order and therefore dependency flow in source-build
  2. During the repo builds, the intermediate sourcebuild packages for these dependencies will be used. This eliminates prebuilts and will aid in the prebuilt detection UX at the repo level.
Repo Missing Dependency Version.Details Dependency Missing
installer aspnetcore  
installer clicommandlineparser x
installer msbuild  
installer nuget.client  
installer roslyn  
installer runtime  
installer sdk  
installer source-build  
installer templating  
installer test-templates  
installer xliff-tasks  
installer vstest  
@MichaelSimons MichaelSimons added the area-infra Source-build infrastructure and reporting label Jun 17, 2021
@MichaelSimons MichaelSimons self-assigned this Jun 17, 2021
@MichaelSimons
Copy link
Member Author

aspnetcore and roslyn ArPow changes have not flown in yet. ArPow versions will come in with dotnet/installer#10856.

The fsharp version is VS16.10 which is not ArPow enabled. Following up with the F# team to see if/when a VS17.0 version will get picked up.

@MichaelSimons
Copy link
Member Author

The clicommandlineparser dependency is blocked on dotnet/CliCommandLineParser#186

@MichaelSimons MichaelSimons mentioned this issue Jun 18, 2021
Merged
@MichaelSimons
Copy link
Member Author

Microsoft.DotNet.Cli.CommandLine is not appearing in the installer's prebuilt report therefore I don't think this should be added.

@MichaelSimons MichaelSimons mentioned this issue Jun 23, 2021
Merged
@MichaelSimons MichaelSimons added this to the 6.0 Preview6 milestone Jul 8, 2021
@MichaelSimons MichaelSimons removed their assignment Dec 1, 2021
@MichaelSimons MichaelSimons added area-arcade Common Arcade source-build infra and removed area-infra Source-build infrastructure and reporting labels Jul 12, 2022
@MichaelSimons MichaelSimons removed this from the 6.0 Preview6 milestone Oct 14, 2022
@MichaelSimons
Copy link
Member Author

This work was completed in 6.0 as part of the ArPow work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-arcade Common Arcade source-build infra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelSimons