Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Roslyn on Linux #3

Closed
ellismg opened this issue Aug 12, 2016 · 4 comments
Closed

Build Roslyn on Linux #3

ellismg opened this issue Aug 12, 2016 · 4 comments
Labels
area-upstream-fix Needs a change in a contributing repo

Comments

@ellismg
Copy link
Contributor

ellismg commented Aug 12, 2016

cibuild.sh will actually build a fair amount of the product, but it also runs tests and does not produce nuget packages.

The build is also not an "official" build so the assembly versions are all wrong.
@ellismg ellismg added this to the 1.0.X milestone Aug 12, 2016
@ellismg
Copy link
Contributor Author

ellismg commented Aug 12, 2016

cibuild.sh had a bug where it would not respect the --release flag. I upstreamed a fix for this to master (dotnet/roslyn#12789), but I haven't tried to get it ported into the official release branch, instead I'm just using a local copy of the patch.

@ellismg
Copy link
Contributor Author

ellismg commented Aug 12, 2016

Since NuGet packages are built using a CS script, I added both "VbcCore" and "CscCore" to CrossPlatform.sln so they can be built during the build.

I then wrote a script similar to build/BuildNuGets.csx that builds the nupkgs we care about using the XPlat version of NuGet from NuGet.Client.

We'll need to upstream both of these sets of changes.

@ellismg ellismg added fixed-locally area-upstream-fix Needs a change in a contributing repo labels Aug 12, 2016
@jaredpar
Copy link
Member

Do you have a Roslyn branch where you are making the fixes that you need to upstream?

@ellismg
Copy link
Contributor Author

ellismg commented Aug 12, 2016

Just local patches at the moment.

@ellismg ellismg closed this as completed Feb 4, 2017
@MichaelSimons MichaelSimons mentioned this issue Oct 4, 2022
Closed
@MichaelSimons MichaelSimons mentioned this issue Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-upstream-fix Needs a change in a contributing repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredpar @ellismg