Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build prefers prebuilt nuget packages over source-built nuget packages in some cases #4208

Closed
tmds opened this issue Mar 12, 2024 · 7 comments

Comments

@tmds
Copy link
Member

tmds commented Mar 12, 2024

While validating dotnet/source-build-externals#281 I see the following (vmr main, --online build):

In the SDK that gets built ./sdk/9.0.100-preview.3.24161.1/DotnetTools/dotnet-user-jwts/9.0.0-preview.3.24158.2/tools/net9.0/any/Microsoft.IdentityModel.Tokens.dll has /vmr/src/source-build-externals/artifacts/sb/src/src/azure-activedirectory-identitymodel-extensions-for-dotnet/src/Microsoft.IdentityModel.Tokens/obj/Release/netstandard2.0/Microsoft.IdentityModel.Tokens.pdb stored for the pdb path.

This path is where the prebuilt nuget package was built.
In other words: the build is consuming the prebuilt nuget package when building dotnet-user-jwts.

The source-built nuget package for Microsoft.IdentityModel.Tokens.7.1.2.nupkg has a mapped path (as intended by the PR): /_/src/source-build-externals/artifacts/sb/src/src/azure-activedirectory-identitymodel-extensions-for-dotnet/src/Microsoft.IdentityModel.Tokens/obj/Release/netstandard2.0/Microsoft.IdentityModel.Tokens.pdb.

cc @MichaelSimons @mthalman @omajid

@mthalman
Copy link
Member

These two pdb paths look the same to me. What am I missing?

@tmds
Copy link
Member Author

tmds commented Mar 12, 2024

/vmr/src/... is where the prebuilt nuget package dll was built.

/_/src/... is where the source-build dll got path-mapped with DeterministicSourcePaths (dotnet/source-build-externals#281).

@tmds
Copy link
Member Author

tmds commented Mar 13, 2024

@omajid pointed me to #4206 which is probably the root cause of this issue. When #4206 is fixed, I'll verify this issue is resolved and close it.

@mthalman
Copy link
Member

@omajid pointed me to #4206 which is probably the root cause of this issue. When #4206 is fixed, I'll verify this issue is resolved and close it.

That issue only applies when using the official SDK Preview 2 release for your toolset.

@tmds
Copy link
Member Author

tmds commented Mar 13, 2024

This is the version that my build used:

Welcome to .NET 9.0!
---------------------
SDK Version: 9.0.100-preview.2.24154.2

@mthalman
Copy link
Member

This is the version that my build used:

Welcome to .NET 9.0!
---------------------
SDK Version: 9.0.100-preview.2.24154.2

Yeah, that build does contain the behavior change described in #4206.

@MichaelSimons
Copy link
Member

Closing in preference of using #4206 to track this problem.

@MichaelSimons MichaelSimons closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants