Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage 2 Builds failing during runtime build #4355

Closed
Winniexu01 opened this issue Apr 24, 2024 · 8 comments
Closed

Stage 2 Builds failing during runtime build #4355

Winniexu01 opened this issue Apr 24, 2024 · 8 comments
Labels
ops-monitor Issues created/handled by the source build monitor role

Comments

@Winniexu01
Copy link
Member

Build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2437450&view=logs&j=3121c41d-6088-53a5-4ef6-9a86f3460fe9&t=334539f4-dcef-5cad-a240-02997b3146e7

Error:

/vmr/src/runtime/artifacts/sb/package-cache/microsoft.dotnet.apicompat.task/9.0.100-preview.4.24223.12/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error : API compatibility errors between 'ref/net9.0/System.Private.CoreLib.dll' (left) and 'lib/net9.0/System.Private.CoreLib.dll' (right): [/vmr/src/runtime/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
/vmr/src/runtime/artifacts/sb/package-cache/microsoft.dotnet.apicompat.task/9.0.100-preview.4.24223.12/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error CP0021: Cannot add constraint 'T:System.Enum' on type parameter 'TEnum' of 'System.Enum.TryFormat<TEnum>(TEnum, System.Span<char>, out int, System.ReadOnlySpan<char>)'. [/vmr/src/runtime/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
/vmr/src/runtime/artifacts/sb/package-cache/microsoft.dotnet.apicompat.task/9.0.100-preview.4.24223.12/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error CP0021: Cannot add constraint 'T:System.Enum' on type parameter 'T' of 'System.Collections.Generic.EnumEqualityComparer<T>'. [/vmr/src/runtime/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
/vmr/src/runtime/artifacts/sb/package-cache/microsoft.dotnet.apicompat.task/9.0.100-preview.4.24223.12/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true' [/vmr/src/runtime/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    0 Warning(s)
    4 Error(s)
@Winniexu01 Winniexu01 added the ops-monitor Issues created/handled by the source build monitor role label Apr 24, 2024
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@oleksandr-didyk
Copy link
Contributor

@mthalman would you know by any chance who from runtime we should ping for this issue? I looked through runtime's issues but did find a mention for something similar

@mthalman
Copy link
Member

cc @ViktorHofer, @ericstj

@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 24, 2024

That's due to dotnet/sdk@170fa21. @ericstj has a reactionary change ready for runtime.

@ericstj
Copy link
Member

ericstj commented Apr 24, 2024

I was planning to add those when we ingested APICompat to runtime. Instead I went ahead and made the fixes. I still think source build will be broken because it will insist on the suppressions being up to date / as will runtime.
dotnet/runtime#101504

@ellahathaway
Copy link
Member

@ViktorHofer is adding a patch to disable APICompat in runtime which should resolve the issues temporarily.

@ellahathaway ellahathaway changed the title CentOSStream9_Online_CurrentSourceBuiltSdk_x64 is failed during runtime build Stage 2 Builds failing during runtime build Apr 30, 2024
@MichaelSimons
Copy link
Member

[Triage] We are expecting this to be unblocked by the #4362 that needs to be done in conjunction with with latest sdk flow.

@ellahathaway
Copy link
Member

I think this was fixed since we rebootstrapped and the latest sdk flow went in. Leaving #4362 open since we continue to rebootstrap to get builds green post the installer -> sdk merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ops-monitor Issues created/handled by the source build monitor role
Projects
Archived in project
Development

No branches or pull requests

7 participants