Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Spark 2.3 Support #895

Merged
merged 10 commits into from
Apr 19, 2021
Merged

Drop Spark 2.3 Support #895

merged 10 commits into from
Apr 19, 2021

Conversation

suhsteve
Copy link
Member

@suhsteve suhsteve commented Apr 8, 2021 •
edited
Loading

This PR removes Support for Spark 2.3, this includes:

  • Removing microsoft-spark 2.3 jar
  • Removing code paths related to 2.3
  • update/merge/rename tests

@suhsteve suhsteve self-assigned this Apr 8, 2021
@suhsteve suhsteve added the enhancement New feature or request label Apr 8, 2021
@suhsteve suhsteve added this to the 2.0.0 milestone Apr 8, 2021
This was linked to issues Apr 8, 2021
[BUG]: Linux + Spark 2.3.0 + UDFs do not work #753
Open
Plan for dropping Spark 2.3 support in the 2.0 release #839
Closed
@suhsteve suhsteve removed a link to an issue Apr 8, 2021
[BUG]: Linux + Spark 2.3.0 + UDFs do not work #753
Open
@imback82
Copy link
Contributor

imback82 commented Apr 9, 2021

Is this still a work in progress?

@suhsteve
Copy link
Member Author

suhsteve commented Apr 9, 2021

Is this still a work in progress?

Was waiting on the other PRs to get merged.

@suhsteve suhsteve marked this pull request as ready for review April 9, 2021 21:45
@suhsteve suhsteve changed the title [WIP] Drop Spark 2.3 Support Drop Spark 2.3 Support Apr 9, 2021
imback82
imback82 reviewed Apr 19, 2021
View reviewed changes
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (few minor comments), thanks @suhsteve!

src/csharp/Microsoft.Spark.Worker/Processor/BroadcastVariableProcessor.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark.Worker/Utils/SettingUtils.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark.Worker/Utils/SettingUtils.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/RDD.cs Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/DataFrame.cs Show resolved Hide resolved
@imback82 imback82 merged commit 5e6a142 into dotnet:main Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imback82 imback82 imback82 approved these changes

Assignees

@suhsteve suhsteve

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Plan for dropping Spark 2.3 support in the 2.0 release
2 participants
@suhsteve @imback82