Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFM trimming, and elimination of net4* targeting in Linux source-build #5192

Closed
4 tasks
Tracked by #3014
mmitche opened this issue Sep 1, 2022 · 5 comments · Fixed by #6234
Closed
4 tasks
Tracked by #3014

TFM trimming, and elimination of net4* targeting in Linux source-build #5192

mmitche opened this issue Sep 1, 2022 · 5 comments · Fixed by #6234
Labels
area: infra The issue is related to engineering infrastructure. triaged The issue was evaluated by the triage team, placed on correct area, next action defined.

Comments

@mmitche
Copy link
Member

mmitche commented Sep 1, 2022

Description

Trim away unneeded TFMs, and conditionalize away non-applicable TFMs for Linux source build.

Requires dotnet/source-build#3013. source-build net4* targeting elimination required dotnet/source-build#2974

The purpose of this operation is twofold:

  • Reduce the number of TFMs present overall in .NET's build, potentially improving build time.
  • Eliminate framework TFMs, drastically reducing the size of the source build repository size.

When TFMs other than the latest .NET Core TFM are targeted in source-build, the reference assets for that TFM must be provided via a source build reference package. This is a 'text only' package that is assembled from IL at the beginning of the build to satisfy the required reference assets. In Microsoft's build, these would be restored from the internet, but in source build this is not allowed.

These SBRPs are large. All told, the total size contribution for just the netframework 4* TFMs is around 3GB. Not only does this have a significant contribution to the source build repo size, but it also affects build time. For Linux source build, we spend large amounts of time building assets that are simply thrown away at the end.

An 'ideal' would be a single TFM used throughout all of the .NET build, source build or otherwise. This is not possible. There are legitimate reasons to target older TFMs, especially netstandard. However, we should be able to justify each additional TFM.

To complete this work, repositories will use the tooling provided via dotnet/source-build#2901 to identify the TFMs in use in their repository. For each TFM, they should do the following:

  • If the TFM can be eliminated, or upgraded to latest (e.g. target the latest netcore explicitly, or use net472), do so. netframework TFM removal for tools and internal code is likely low hanging fruit.
  • Requires Design for unified behavior controls source-build#2974 If the TFM is a framework TFM, it should be conditionalized out in source build for Linux.

It is a goal that the form of this conditionalization remain consistent across projects, and used relatively sparingly. How this conditionalization should be done will be designed in dotnet/source-build#2974. Once that is done, this issue will be updated with implementation details.

@mmitche
Copy link
Member Author

mmitche commented Sep 1, 2022

This is .NET 8 work

@vlada-shubina vlada-shubina added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label Sep 6, 2022
@vlada-shubina
Copy link
Member

  • let's discuss with Visual Studio if they need full framework versions
  • can we drop full framework support if Visual Studio is not using it?

@mmitche if we cannot drop support of full/standard, will excluding them from source build help the purpose?

@mmitche
Copy link
Member Author

mmitche commented Sep 6, 2022

Yeah, please wait till we have the right control schema in place (dotnet/source-build#2974) so that this as 'clean' as possible in your projects.

@vlada-shubina
Copy link
Member

We need full framework support for VS.
We can consider building for latest TFM for source-build only if required.

@mmitche
Copy link
Member Author

mmitche commented Sep 8, 2022

That will be required, but wait for the control scheme to do any implementation.

@vlada-shubina vlada-shubina added the area: infra The issue is related to engineering infrastructure. label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infra The issue is related to engineering infrastructure. triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants