Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should ClientBase<T> be exposed to implement IDisposable in contract #2022

Closed
zhenlan opened this issue Jun 30, 2017 · 2 comments
Closed

Should ClientBase<T> be exposed to implement IDisposable in contract #2022

zhenlan opened this issue Jun 30, 2017 · 2 comments
Assignees
Milestone

Comments

@zhenlan
Copy link
Member

zhenlan commented Jun 30, 2017

Here is a feedback from a customer using WCF connected service

I noticed that connection management has changed slightly. The codegen’d webclient objects don’t implement IDisposable. We can always wrap the client object to provide this capability, but it’d be super convenient if the codegen did this for us.

It looks like ClientBase<T> does not implement IDisposable in contract but its implementation does have IDisposable. Would like to see if there is any particular reason for this.

@zhenlan
Copy link
Member Author

zhenlan commented Jul 10, 2017

We will update ClientBase<T> to implement IDisposable in contract.

@christopherseeley
Copy link

Has this been released yet? Using System.ServiceModel.Primitives version 4.1.1 and ClientBase doesn't implement IDisposable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants