Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ClientBase<TChannel>.Close() #2282

Closed
EPinci opened this issue Sep 12, 2017 · 5 comments
Closed

Missing ClientBase<TChannel>.Close() #2282

EPinci opened this issue Sep 12, 2017 · 5 comments
Assignees
Milestone

Comments

@EPinci
Copy link

EPinci commented Sep 12, 2017

Hello,

Looks like the method ClientBase.Close() is no longer there.
How do I close a client?

Thank you.

@zhenlan
Copy link
Member

zhenlan commented Sep 12, 2017

Hi @EPinci, you can call Dispose() on it

@zhenlan zhenlan added this to the 2.1.0 milestone Sep 12, 2017
@EPinci
Copy link
Author

EPinci commented Sep 13, 2017

Understood, thank you.

Can I ask you to comment on this article: this is widely reported around and does it still apply?

Thank you.

StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this issue Feb 15, 2018
StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this issue Feb 15, 2018
* Fixes dotnet#2282
* Including a simple unit test.
@ericstj
Copy link
Member

ericstj commented Aug 8, 2018

You might consider bringing this back in the references. We brought back all Close() members in CoreFx and I see you kept the Close method in the implementation. The Close/Dispose confusion didn't outweigh the sheer number of hits on the missing Close methods.

You might also consider looking at a diff for other types that were subsetted "on principle". We've backed off most of those principles since 2.0. /cc @terrajobst @danmosemsft

@StephenBonikowsky
Copy link
Member

@ericstj I opened #3101 to do this work.

@ericstj
Copy link
Member

ericstj commented Aug 8, 2018

Sorry I missed that this one was actually fixed. Thanks for opening the new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants