Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xUnit warnings #4006

Closed
12 tasks done
StephenBonikowsky opened this issue Oct 30, 2019 · 6 comments
Closed
12 tasks done

Fix xUnit warnings #4006

StephenBonikowsky opened this issue Oct 30, 2019 · 6 comments
Assignees
@imcarolwang
Milestone
5.0

Comments

@StephenBonikowsky
Copy link
Member

StephenBonikowsky commented Oct 30, 2019 •
edited by imcarolwang
Loading

  • master (no need to go into release/3.1.0)

Fix all of the xUnit warnings we are currently suppressing.
Add to this list below if I missed any.
@StephenBonikowsky StephenBonikowsky added this to the 5.0 milestone Oct 30, 2019
@imcarolwang imcarolwang mentioned this issue Oct 31, 2019
Merged
@StephenBonikowsky
Copy link
Member Author

StephenBonikowsky commented Oct 31, 2019 •
edited
Loading

Added master and release/3.1 check boxes.

This was referenced Nov 4, 2019
Merged
Merged
@StephenBonikowsky
Copy link
Member Author

Removed from the 3.1 project, no need to cherry-pick to 3.1 branch.

This was referenced Nov 7, 2019
Merged
Merged
@imcarolwang
Copy link
Contributor

imcarolwang commented Nov 18, 2019 •
edited
Loading

Hi @StephenBonikowsky, I just found the PRs I submitted earlier only handled xUnit warnings in test projects under System.Private.ServiceModel, and there're more test folders/projects not checked.

I'm planning to create separated PRs for each xUnit warning fixing for the remaining folders. Please help review. Sorry for the extra effort/inconvenience brought.

@imcarolwang imcarolwang mentioned this issue Nov 18, 2019
Merged
@StephenBonikowsky
Copy link
Member Author

Ok, will do.

This was referenced Nov 20, 2019
Merged
Merged
Merged
Merged
Merged
Merged
@imcarolwang imcarolwang mentioned this issue Dec 3, 2019
Merged
@imcarolwang
Copy link
Contributor

Close as all suppressed xUnit warnings have been removed from test projects.

@StephenBonikowsky
Copy link
Member Author

Terrific, thanks @imcarolwang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imcarolwang imcarolwang

Labels
None yet
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@StephenBonikowsky @imcarolwang