Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding IDisposable to ClientBase<TChannel> #2066

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Adding IDisposable to ClientBase<TChannel> #2066

merged 1 commit into from
Jul 19, 2017

Conversation

mconnew
Copy link
Member

@mconnew mconnew commented Jul 13, 2017

Fixes #2022

zhenlan
zhenlan approved these changes Jul 18, 2017
View reviewed changes
Copy link
Member

@zhenlan zhenlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mconnew.

@mconnew mconnew merged commit 39de30d into dotnet:master Jul 19, 2017
@mconnew mconnew deleted the Issue2022 branch July 19, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenlan zhenlan zhenlan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mconnew @zhenlan @dnfclas