Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding IDisposable to ClientBase<TChannel> #2066

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Adding IDisposable to ClientBase<TChannel> #2066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/System.ServiceModel.Primitives/ref/System.ServiceModel.Primitives.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ protected ChannelFactory(System.Type channelType) { }
public virtual TChannel CreateChannel(System.ServiceModel.EndpointAddress address, System.Uri via) { return default(TChannel); }
protected override System.ServiceModel.Description.ServiceEndpoint CreateDescription() { return default(System.ServiceModel.Description.ServiceEndpoint); }
}
public abstract partial class ClientBase<TChannel> : System.ServiceModel.ICommunicationObject where TChannel : class
public abstract partial class ClientBase<TChannel> : System.IDisposable, System.ServiceModel.ICommunicationObject where TChannel : class
{
protected ClientBase() { }
protected ClientBase(System.ServiceModel.Channels.Binding binding, System.ServiceModel.EndpointAddress remoteAddress) { }
Expand Down Expand Up @@ -139,6 +139,7 @@ void System.ServiceModel.ICommunicationObject.EndClose(System.IAsyncResult resul
void System.ServiceModel.ICommunicationObject.EndOpen(System.IAsyncResult result) { }
void System.ServiceModel.ICommunicationObject.Open() { }
void System.ServiceModel.ICommunicationObject.Open(System.TimeSpan timeout) { }
void System.IDisposable.Dispose() { }
protected delegate System.IAsyncResult BeginOperationDelegate(object[] inValues, System.AsyncCallback asyncCallback, object state);
protected partial class ChannelBase<T> : System.IDisposable, System.ServiceModel.Channels.IChannel, System.ServiceModel.Channels.IOutputChannel, System.ServiceModel.Channels.IRequestChannel, System.ServiceModel.IClientChannel, System.ServiceModel.ICommunicationObject, System.ServiceModel.IContextChannel, System.ServiceModel.IExtensibleObject<System.ServiceModel.IContextChannel> where T : class
{
Expand Down