Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove System.Security.Principal.Windows reference #5229

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Remove System.Security.Principal.Windows reference #5229

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e044fb5
Remove System.Security.Principal.Windows reference
ViktorHofer Aug 4, 2023
f75b68d
Update Versions.props
ViktorHofer Aug 4, 2023
9c63a20
Update System.ServiceModel.NetFramingBase.csproj
ViktorHofer Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
<!-- CoreFx dependencies -->
<PropertyGroup>
<SystemReflectionDispatchProxyPackageVersion>4.7.1</SystemReflectionDispatchProxyPackageVersion>
<SystemSecurityPrincipalWindowsPackageVersion>5.0.0</SystemSecurityPrincipalWindowsPackageVersion>
<SystemSecurityCryptographyXmlPackageVersion>6.0.1</SystemSecurityCryptographyXmlPackageVersion>
<MicrosoftExtensionsObjectPoolVersion>6.0.16</MicrosoftExtensionsObjectPoolVersion>
</PropertyGroup>
Expand Down
6 changes: 1 addition & 5 deletions src/System.ServiceModel.NetFramingBase/src/System.ServiceModel.NetFramingBase.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<CLSCompliant>true</CLSCompliant>
<IsPackable>true</IsPackable>
<IsShipping>$(Ship_WcfPackages)</IsShipping>
<!-- TODO: Make this net462 and netstandard2.0 after it's multi-targetting .NET Framework -->
<!-- TODO: Make this net462 and netstandard2.0 after it's multi-targetting .NET Framework -->
ViktorHofer marked this conversation as resolved.
Show resolved Hide resolved
<TargetFramework>net6.0</TargetFramework>
<RootNamespace>System.ServiceModel</RootNamespace>
<DebugType>full</DebugType>
Expand All @@ -18,10 +18,6 @@
<ProjectReference Include="..\..\System.ServiceModel.Primitives\src\System.ServiceModel.Primitives.csproj" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="System.Security.Principal.Windows" Version="$(SystemSecurityPrincipalWindowsPackageVersion)" />
</ItemGroup>

<!--The default source produced by the Arcade SDK does not work with the checked-in source file SR.cs (class/namespace/filename)-->
<ItemGroup>
<EmbeddedResource Update="Resources\Strings.resx">
Expand Down