Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RC1 release notes #570

Merged
merged 1 commit into from
Dec 10, 2015
Merged

Update RC1 release notes #570

merged 1 commit into from
Dec 10, 2015

Conversation

hongdai
Copy link
Contributor

@hongdai hongdai commented Dec 2, 2015

  • The scenario table are updated according to test results on Asp.Net 5 and UWP.

@roncain
Copy link
Contributor

roncain commented Dec 2, 2015

If you have issue numbers, would you mind adding a "more..." hyperlink to it like the other places with known issues?

@hongdai
Copy link
Contributor Author

hongdai commented Dec 2, 2015

I will add the issue numbers I am aware of.

@@ -28,9 +28,9 @@ Supported features
||NetHttpBinding|:white_check_mark: | :white_check_mark: | :white_check_mark: | :warning: [more...](https://github.com/dotnet/wcf/issues/534) |
||NetTcpBinding|:white_check_mark: | :white_check_mark: | :white_check_mark: | :warning: [more...](https://github.com/dotnet/wcf/issues/534) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can "more..." point to multiple issues (if there are more than one)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make "more..." a query, but I couldn't find any clean way to form accurate queries unique to the feature for that row in the table. I think it might be reasonable to make the NET Native and Linux columns use a query for labels "bug" and "NET Native" (or "Linux"). What do you think of adding new labels that correspond to the cells in the "Feature" column? It would allow self-maintaining queries and give us a better way to indicate "what feature is affected by this bug?".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a query for RC1 only bugs. The issues status reflects the latest status,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Let's put more thoughts in this and not block this PR by it.

BTW, can we update the OS X column from ⚠️ to ❓

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's make OSX all ❓. And I agree, let's merge the PR and continue refining this table as we decide on improvements.

@roncain
Copy link
Contributor

roncain commented Dec 3, 2015

Issue #567 recommends changing the legend, which would affect many of the cells in this table. I like the proposed legend changes and recommend we expand this PR to that if fixes the legend as well as all the cells. We can make a separate PR to convert all the "more..." links to queries.

:x: -- Not supported
:white_check_mark: -- Works with no known major issues
:warning: -- Partially works with known issues or only partially tested
:x: -- Does not work


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: remove empty line

@hongdai hongdai force-pushed the releasenote branch 2 times, most recently from df45087 to b61253c Compare December 9, 2015 19:34
|MessageVersion|SOAP 1.1 UTF8|:white_check_mark: | :white_check_mark: | :white_check_mark: | :question: |
||SOAP 1.2 UTF8|:white_check_mark: | :white_check_mark: | :white_check_mark: | :question: |
|Contracts | DataContract | :warning:[more...](https://github.com/dotnet/wcf/issues/325) | :white_check_mark: | :white_check_mark: | :question: |
| | XmlSerializer | :white_check_mark: | :white_check_mark: | :white_check_mark: | :question: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should (XmlSerializer - UWP) be marked as ⚠️ due to #555 and #572?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. I'll update it.

* The scenario table are updated according to test results on Asp.Net 5 and UWP.
@zhenlan
Copy link
Member

zhenlan commented Dec 10, 2015

LGTM. Thanks @hongdai.

@roncain
Copy link
Contributor

roncain commented Dec 10, 2015

LGTM

hongdai added a commit that referenced this pull request Dec 10, 2015
@hongdai hongdai merged commit 540cd05 into dotnet:master Dec 10, 2015
@hongdai hongdai deleted the releasenote branch January 4, 2016 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants