Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite XAML build to use a Roslyn source generator #6974

Open
pchaurasia14 opened this issue Aug 29, 2022 · 9 comments
Open

Rewrite XAML build to use a Roslyn source generator #6974

pchaurasia14 opened this issue Aug 29, 2022 · 9 comments
Labels
Investigate Requires further investigation by the WPF team.
Milestone

Comments

@pchaurasia14
Copy link
Member

Rewrite the XAML build process to use a Roslyn code generator instead of GenerateTemporaryTargetAssembly and related tasks.

@lindexi
Copy link
Member

lindexi commented Sep 1, 2022

Looking forward to this improvement

@miloush
Copy link
Contributor

miloush commented Sep 1, 2022

What would be the benefits of spending time and resources on this?

@lindexi
Copy link
Member

lindexi commented Sep 1, 2022

@miloush Such as remove the *_wpftmp.csproj files.

@miloush
Copy link
Contributor

miloush commented Sep 1, 2022

@lindexi why is that a problem? Is there something we cannot currently do that a source generator would fix?

@lindexi
Copy link
Member

lindexi commented Sep 1, 2022

@miloush Some friends are troubled by the fact that sometimes the *_wpftmp.csproj file cannot be deleted automatically. And I think we can fix this without source generator...

@singhashish-wpf singhashish-wpf added Investigate Requires further investigation by the WPF team. and removed Untriaged labels Sep 2, 2022
@omariom
Copy link
Contributor

omariom commented Sep 2, 2022

What would be the benefits of spending time and resources on this?

Potentially faster builds.

@lindexi
Copy link
Member

lindexi commented Sep 21, 2022

@miloush Maybe can fix #5711

@lindexi
Copy link
Member

lindexi commented Oct 13, 2022

Maybe can fix #4544

I've tried to fix this before without success. One of the reasons is that it is difficult to change the current logical code.

@miloush
Copy link
Contributor

miloush commented Oct 13, 2022

I went through the code and this is a big task with a lot of test cases needed. If someone goes ahead, please make sure it works with VB.NET projects. (And obviously we lose other languages with CodeDom providers but I am not extremely concerned about those.)

@karelz karelz added this to the Future milestone Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigate Requires further investigation by the WPF team.
Projects
None yet
Development

No branches or pull requests

6 participants