fix(useSelect): preventDefault on item props onMouseDown #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
force-pushed
the
fix/prevent-defrault-on-mouse-down
branch
from
cd3995d
to
0c818bd
Compare
silviuaavram
force-pushed
the
fix/prevent-defrault-on-mouse-down
branch
from
0c818bd
to
bc04626
Compare
|
🎉 This PR is included in version 8.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Prevent default on getItemProps onMouseDown for useSelect.
Closes #1537.
Why:
Keep the focus on the toggle button when item is selected by mouse click.
How:
This was overlooked since for very long the focus strategy with useSelect was different (switch between toggle and menu).
Checklist: