Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): add onPress to toggle button props parameter #1548

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Sep 29, 2023

What:
Add onPress optional type to the toggle button functions parameter.

Why:
The getToggleButtonProps can also take onPress in RN which does not exist in the current types.

How:
Add the type to both the downshift/useCombobox and useSelect typ.es

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (05ffa9c) 100.00% compared to head (e176f30) 100.00%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1548   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1724      1724           
  Branches       512       512           
=========================================
  Hits          1724      1724           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silviuaavram silviuaavram merged commit fd6ab68 into master Sep 29, 2023
2 checks passed
@silviuaavram silviuaavram deleted the types/add-on-press branch September 29, 2023 06:41
@github-actions
Copy link

🎉 This PR is included in version 8.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants