Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle custom element IDs on Downshift children (list items, list, input etc) #667

Closed
silviuaavram opened this issue Feb 12, 2019 · 2 comments

Comments

@silviuaavram
Copy link
Collaborator

silviuaavram commented Feb 12, 2019

At the moment the code assumes that the IDs it is adding are permanent. But if the user will change them to fulfil certain scenarios, some functionalities will be broken.

For instance, a user added custom element id on the <li> elements, and the scroll to element functionality was broken, as it could not find the element to scroll to.

I can see 2 options:

  • handle custom IDs if the user overrides them.
  • use another element attribute different from id for the combobox, listbox, label, etc.
@babzcraig
Copy link

@silviuavram if this is till open, I'd like to take it on. I can start with taking a look at the two approaches you mentioned here (and any others that come to my mind) and figuring out pros and cons of each approach.

@silviuaavram
Copy link
Collaborator Author

closing, just found that we already have an id prop for overriding the default ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants