You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment the code assumes that the IDs it is adding are permanent. But if the user will change them to fulfil certain scenarios, some functionalities will be broken.
For instance, a user added custom element id on the <li> elements, and the scroll to element functionality was broken, as it could not find the element to scroll to.
I can see 2 options:
handle custom IDs if the user overrides them.
use another element attribute different from id for the combobox, listbox, label, etc.
The text was updated successfully, but these errors were encountered:
@silviuavram if this is till open, I'd like to take it on. I can start with taking a look at the two approaches you mentioned here (and any others that come to my mind) and figuring out pros and cons of each approach.
At the moment the code assumes that the IDs it is adding are permanent. But if the user will change them to fulfil certain scenarios, some functionalities will be broken.
For instance, a user added custom element id on the
<li>
elements, and the scroll to element functionality was broken, as it could not find the element to scroll to.I can see 2 options:
id
for the combobox, listbox, label, etc.The text was updated successfully, but these errors were encountered: