Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Parameterize android support library to avoid conflicts with other plugins #338

Closed
2 tasks
CSobol opened this issue Jan 24, 2019 · 2 comments
Closed
2 tasks

Comments

@CSobol
Copy link

CSobol commented Jan 24, 2019

I'm submitting a ... (check one with "x"):

  • bug report
  • [ x ] feature request
  • documentation issue

Feature request

  • Similar to android.support library version conflicts #212, this plugin will conflict with other plugins which have hard coded the version of com.android.support they require.

  • Since android >= 7.1.0 and cordova-android >= 6.3.0, cordova has provided a way to parameterize these requirements, allowing them to be specified with a switch at install, or a tag in the root project's config.xml

  • This will set this plugin up to play nicely with other plugins which use the new/modern method of specifying a library, it will also allow it to play nicely with plugins which don't, by allowing the user to specify their version number. In addition, unlike the resolution to android.support library version conflicts #212, this does not require yet another cordova plugin to address the issue.

  • Install instructions will need updating to reflect the available switch.

  • Relevant links

I will be doing this work anyway to resolve an issue. Are you accepting PRs?

@Mapiac
Copy link

Mapiac commented Mar 5, 2019

How is this going? Can I be of help @CSobol ?

@dpa99c dpa99c closed this as completed in 88e3ba1 Mar 6, 2019
@dpa99c
Copy link
Owner

dpa99c commented Mar 6, 2019

Above commit published to npm in v4.0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants