Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaAdmin raises UnsupportedVersion for client-side errors #1627

Closed
jeffwidman opened this issue Nov 8, 2018 · 0 comments
Closed

KafkaAdmin raises UnsupportedVersion for client-side errors #1627

jeffwidman opened this issue Nov 8, 2018 · 0 comments

Comments

@jeffwidman
Copy link
Collaborator

jeffwidman commented Nov 8, 2018

UnsupportedVersionError is intended to indicate a server-side error:

class UnsupportedVersionError(BrokerResponseError):
errno = 35
message = 'UNSUPPORTED_VERSION'
description = 'The version of API is not supported.'

But the new KafkaAdmin class is raising it client-side, without triggering it from the broker... for example:

I understand that semantically this seems like the appropriate error to raise. However, this is confusing when debugging... for a real-life example, see Parsely/pykafka#697. So I strongly feel that we should keep the server-side errors separate from client-side errors, even if all the client is doing is proactively protecting against hitting a situation where the broker would return this error.

I'm not sure of the right exception to raise, probably we should create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant