-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional values to API_VERSIONS for 0.10.x #892
Comments
I believe this has been addressed now -- can we close? |
I guess in general my issue/question was whether the code allows putting in tuples that don't currently exist in For example, can I put in Otherwise it's annoying to have to remember to set the API version to the minimum of brokers / kafka-python highest supported version. |
I'm still confused by what this issue is requesting. Update: Ok, I think I understand now. This makes sense. PR incoming. |
Perfect, thanks! |
Currently
API_VERSIONS
only has one value for 0.10 brokers.For safety, I'm trying to pin the Kafka broker API versions in our code.
If there's a future 0.10.x release that breaks an API, there's no way I can demarcate that our code wasn't expecting anything newer than 0.10.0 API or 0.10.1 API version...
Should we add values for those?
Also, It seems tedious to be adding values every time a new Kafka release happens. Is there something I'm missing? Like can I specify
(0, 10, 0)
in my code? And if an api changes, kafka-python will understand that that means 0.10.0.x?The text was updated successfully, but these errors were encountered: