Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DKG share index uses uint32, but the tbls scheme uses 16bit #46

Open
CluEleSsUK opened this issue Feb 2, 2023 · 1 comment
Open

DKG share index uses uint32, but the tbls scheme uses 16bit #46

CluEleSsUK opened this issue Feb 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@CluEleSsUK
Copy link

Here in the tBLS signing (which is used for partial signatures) the index is a 16bit int:

if len(signature) != s.sigGroup.PointLen()+2 {

Throughout the DKG, a uint32 is used:

type DistKeyShare struct {

I haven't actually seen this break anything, but maybe it's a limit for large DKGs!

@CluEleSsUK CluEleSsUK added the bug Something isn't working label Feb 2, 2023
@CluEleSsUK
Copy link
Author

It's possibe the indexes are distinct and I've also misunderstood though - open to education (maybe the 16bit one is just for coefficients?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant