Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch object should be non-optional parameter to the selector #171

Open
bmourad01 opened this issue Mar 3, 2022 · 0 comments
Open

Patch object should be non-optional parameter to the selector #171

bmourad01 opened this issue Mar 3, 2022 · 0 comments

Comments

@bmourad01
Copy link
Contributor

The patch object is required for updating congruence information during code generation, since new temporaries may be created after the linear SSA pass. Currently, the only use case is generating the conditional moves to hold the result of a comparison:

| None -> KB.return ()

If the patch remains optional, then it should error here. A better solution may be to just require a patch, which would require updating the relevant unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant