-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scr_ecto-103] Improve options/configuration described in README #104
base: main
Are you sure you want to change the base?
[scr_ecto-103] Improve options/configuration described in README #104
Conversation
A fellow Elixir-er kindly helped me out with the build issue at https://github.com/theirishpenguin/scrivener_ecto/pull/1/files Looking at that PR, it seems like there is an issue building scrivener_ecto with |
@theirishpenguin We have updated the master branch of Scrivener_Ecto to support OTP 26. If you want to rebase your PR work here off the current master, we can look at getting these documentation changes in. |
4947391
to
2bde3cf
Compare
2bde3cf
to
b99cc00
Compare
@cpjolicoeur Thanks 🙌 I've just rebased this PR now off the current master. |
abdc4ae
to
b99cc00
Compare
I have tried to kick off the build again with a "reinitialise checks" commit, but it seems like that needs approval from a maintainer. (I did have a few problems with that commit - all fixed now - so maybe that is why it requires manual approval). Is it possible for someone to kick off a build on this PR? |
The Problem
The README does not mention options such as :allow_overflow_page_number and direct configuration such as :max_page_size. This is noted in issue #103
This PR is to (make a start at least) on correcting that.