fix(item): tappable does not make ion-label pointer-event:none

ionic-team · Dec 8, 2016 · 4512c5c · 4512c5c
1 parent 25e581a
commit 4512c5c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/src/components/item/test/buttons/app-module.ts b/src/components/item/test/buttons/app-module.ts
@@ -9,6 +9,10 @@ export class E2EPage {
   testClick(ev: any) {
     console.log('CLICK!', ev.target.tagName, ev.target.textContent.trim());
   }
+
+  testClickOutsize(ev: any) {
+    console.log('CLICK OUTSIDE!', ev.target.tagName, ev.target.textContent.trim());
+  }
 }
 
 @Component({

diff --git a/src/components/item/test/buttons/main.html b/src/components/item/test/buttons/main.html
@@ -33,7 +33,7 @@
     button[ion-item] danger
   </button>
 
-  <ion-item>
+  <ion-item (click)="testClickOutsize($event)">
     <button ion-button item-left (click)="testClick($event)">Default</button>
     Inner Buttons
     <button ion-button outline item-right (click)="testClick($event)">Outline</button>
@@ -111,6 +111,17 @@ <h3>ng-for {{i}}</h3>
     <ion-badge item-right>260k</ion-badge>
   </button>
 
+  <ion-item (click)="testClickOutsize($event)">
+    <div>
+      <button ion-button icon-only clear item-right (click)="testClick($event)">
+          <ion-icon name="remove-circle"></ion-icon>
+      </button>
+      <button ion-button icon-only clear item-right (click)="testClick($event)">
+          <ion-icon name="add-circle"></ion-icon>
+      </button>
+    </div>
+  </ion-item>
+
 </ion-content>
 
 

diff --git a/src/themes/normalize.scss b/src/themes/normalize.scss
@@ -156,8 +156,7 @@ textarea {
 }
 
 a ion-label,
-button ion-label,
-[tappable] ion-label {
+button ion-label {
   pointer-events: none;
 }