fix(header): optional ViewController injection

ionic-team · Jun 17, 2016 · 5a85d82 · 5a85d82
1 parent 64b8678
commit 5a85d82
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 26 deletions.
diff --git a/src/components/button/test/basic/main.html b/src/components/button/test/basic/main.html
@@ -1,7 +1,11 @@
+<ion-header>
+
+  <ion-toolbar>
+    <ion-title>Default Buttons</ion-title>
+  </ion-toolbar>
+
+</ion-header>
 
-<ion-toolbar>
-  <ion-title>Default Buttons</ion-title>
-</ion-toolbar>
 
 <ion-content padding style="text-align:center">
 

diff --git a/src/components/toolbar/toolbar.ts b/src/components/toolbar/toolbar.ts
@@ -12,41 +12,23 @@ import {ViewController} from '../nav/view-controller';
   selector: 'ion-header'
 })
 export class Header {
-  private _h: number = 0;
 
-  constructor(viewCtr: ViewController, private _elementRef: ElementRef) {
-    viewCtr.setHeader(this);
+  constructor(@Optional() viewCtr: ViewController) {
+    viewCtr && viewCtr.setHeader(this);
   }
 
-  setHeight(heightPixels: number) {
-    this._h = heightPixels;
-    this._elementRef.nativeElement.style.height = (heightPixels > 0 ? heightPixels + 'px' : '');
-  }
-
-  getHeight(): number {
-    return this._h;
-  }
 }
 
 
 @Directive({
   selector: 'ion-footer'
 })
 export class Footer {
-  private _h: number = 0;
 
-  constructor(viewCtr: ViewController, private _elementRef: ElementRef) {
-    viewCtr.setFooter(this);
+  constructor(@Optional() viewCtr: ViewController) {
+    viewCtr && viewCtr.setFooter(this);
   }
 
-  setHeight(heightPixels: number) {
-    this._h = heightPixels;
-    this._elementRef.nativeElement.style.height = (heightPixels > 0 ? heightPixels + 'px' : '');
-  }
-
-  getHeight(): number {
-    return this._h;
-  }
 }
 
 
@@ -109,7 +91,7 @@ export class ToolbarBase extends Ion {
  * A Toolbar is a generic bar that is positioned above or below content.
  * Unlike a [Navbar](../../nav/Navbar), a toolbar can be used as a subheader.
  * When toolbars are placed within an `<ion-header>` or `<ion-footer>`,
- * they stay fixed in their respective location. When placed within
+ * the toolbars stay fixed in their respective location. When placed within
  * `<ion-content>`, toolbars will scroll with the content.
  *
  *