fix(gestures): detecting swipe angle correctly + sliding item logic fix

ionic-team · Jul 13, 2016 · d230cb4 · d230cb4
1 parent 1ae6619
commit d230cb4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/components/item/item-sliding-gesture.ts b/src/components/item/item-sliding-gesture.ts
@@ -44,8 +44,8 @@ export class ItemSlidingGesture {
     }
 
     // Close open container if it is not the selected one.
-    if (container !== this.openContainer && this.closeOpened()) {
-      return false;
+    if (container !== this.openContainer) {
+      this.closeOpened();
     }
 
     // Try to start gesture

diff --git a/src/components/menu/menu-gestures.ts b/src/components/menu/menu-gestures.ts
@@ -51,12 +51,13 @@ export class MenuContentGesture extends SlideEdgeGesture {
       return true;
     }
 
+    let cosine = Math.cos(ev.angle * (Math.PI / 180));
     if (menu.side === 'right') {
-      if ((ev.angle > 140 && ev.angle <= 180) || (ev.angle > -140 && ev.angle <= -180)) {
+      if (cosine < -0.95) {
         return super.canStart(ev);
       }
     } else {
-      if (ev.angle > -40 && ev.angle < 40) {
+      if (cosine > 0.95) {
         return super.canStart(ev);
       }
     }