Skip to content

Commit

Permalink
fix(toast): remove backdrop, allow user interaction when up
Browse files Browse the repository at this point in the history
Closes #6291
  • Loading branch information
adamdbradley committed May 19, 2016
1 parent fb3a707 commit d4d1f70
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 12 deletions.
12 changes: 8 additions & 4 deletions src/components/toast/toast.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,22 @@ ion-toast {

width: $toast-width;
height: $toast-width;

pointer-events: none;
}

.toast-container {
display: flex;

align-items: center;

button {
padding: 19px 16px 17px;
pointer-events: auto;
}

.toast-button {
padding: 19px 16px 17px;

font-size: 1.5rem;
}
font-size: 1.5rem;
}

.toast-message {
Expand Down
7 changes: 0 additions & 7 deletions src/components/toast/toast.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ export class Toast extends ViewController {
@Component({
selector: 'ion-toast',
template: `
<div (click)="bdClick()" tappable disable-activated class="backdrop" role="presentation"></div>
<div class="toast-wrapper">
<div class="toast-container">
<div class="toast-message" id="{{hdrId}}" *ngIf="d.message">{{d.message}}</div>
Expand Down Expand Up @@ -189,12 +188,6 @@ class ToastCmp {
}
}

bdClick() {
if (this.isEnabled() && this.d.enableBackdropDismiss) {
this.dismiss('backdrop');
}
}

cbClick() {
if (this.isEnabled()) {
this.dismiss('close');
Expand Down
1 change: 0 additions & 1 deletion src/components/toggle/toggle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ export class Toggle implements ControlValueAccessor {
* @private
*/
private _setChecked(isChecked: boolean) {
console.debug('_setChecked')
if (isChecked !== this._checked) {
this._checked = isChecked;
if (this._init) {
Expand Down

1 comment on commit d4d1f70

@manucorporat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good! this makes a lot of sense!

Please sign in to comment.