fix(subHeader): removes borders on android subheaders

Closes #3265
ionic-team · Mar 11, 2015 · ebe3226 · ebe3226
1 parent c18c69f
commit ebe3226
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 0 deletions.
diff --git a/js/angular/controller/navBarController.js b/js/angular/controller/navBarController.js
@@ -414,6 +414,9 @@ function($scope, $element, $attrs, $compile, $timeout, $ionicNavBarDelegate, $io
     $element[isTabsTop ? 'addClass' : 'removeClass']('nav-bar-tabs-top');
   };
 
+  self.hasBarSubheader = function(isBarSubheader) {
+    $element[isBarSubheader ? 'addClass' : 'removeClass']('nav-bar-has-subheader');
+  };
 
   // DEPRECATED, as of v1.0.0-beta14 -------
   self.changeTitle = function(val) {

diff --git a/js/angular/controller/navViewController.js b/js/angular/controller/navViewController.js
@@ -56,6 +56,7 @@ function($scope, $element, $attrs, $compile, $controller, $ionicNavBarDelegate,
 
     $scope.$on('$ionicHistory.deselect', self.cacheCleanup);
     $scope.$on('$ionicTabs.top', onTabsTop);
+    $scope.$on('$ionicSubheader', onBarSubheader);
 
     ionic.Platform.ready(function() {
       if (ionic.Platform.isWebView() && $ionicConfig.views.swipeBackEnabled()) {
@@ -432,6 +433,10 @@ function($scope, $element, $attrs, $compile, $controller, $ionicNavBarDelegate,
     associatedNavBarCtrl && associatedNavBarCtrl.hasTabsTop(isTabsTop);
   }
 
+  function onBarSubheader(ev, isBarSubheader) {
+    var associatedNavBarCtrl = getAssociatedNavBarCtrl();
+    associatedNavBarCtrl && associatedNavBarCtrl.hasBarSubheader(isBarSubheader);
+  }
 
   function getAssociatedNavBarCtrl() {
     if (navBarDelegate) {

diff --git a/js/angular/directive/headerFooterBar.js b/js/angular/directive/headerFooterBar.js
@@ -137,6 +137,7 @@ function headerFooterBarDirective(isHeader) {
               var isSubheader = value.indexOf('bar-subheader') !== -1;
               $scope.$hasHeader = isShown && !isSubheader;
               $scope.$hasSubheader = isShown && isSubheader;
+              $scope.$emit('$ionicSubheader', $scope.$hasSubheader);
             });
             $scope.$on('$destroy', function() {
               delete $scope.$hasHeader;

diff --git a/scss/_bar.scss b/scss/_bar.scss
@@ -264,6 +264,10 @@
 
 .platform-android {
 
+  .nav-bar-has-subheader .bar {
+    border-bottom: 0;
+  }
+
   .bar {
 
     .back-button .icon:before {