fix(alert): unhandled promise exception

ionic-team · Jan 20, 2017 · ee2268f · ee2268f
1 parent 8c4fd56
commit ee2268f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/components/alert/alert-component.ts b/src/components/alert/alert-component.ts
@@ -259,7 +259,9 @@ export class AlertCmp {
     }
 
     if (shouldDismiss) {
-      this.dismiss(button.role);
+      this.dismiss(button.role).catch(() => {
+        console.debug('alert can not be dismissed');
+      });
     }
   }
 

diff --git a/src/components/tabs/test/advanced/app.module.ts b/src/components/tabs/test/advanced/app.module.ts
@@ -81,6 +81,7 @@ export class TabsPage {
               alert.dismiss().then(() => {
                 resolve();
               });
+              return false;
             }
           }
         ]