-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Karma tests click() do not work for links #1310
Comments
Is anyone having the same problem? I think the breakage starts with ionic beta-2 |
Hey @xie1989 , this makes sense. We re-did the click detection system in beta.2. I'll look at this on Monday. I have some ideas to fix this. |
Sounds good. Thanks, @ajoslin! |
Any update here, @ajoslin? |
Apologies, forgot about this yesterday. Just pushed a small addition to disable ionic tap during e2e tests, can you try it out? The nightly build will have the fix within about 20 minutes from this comment. |
Yup, this works. Thanks so much, @ajoslin! |
Actually, I think my celebration was premature. It still only works for button clicks but not clicks on anchor elements for some reason. |
Hmm.. what browser/device are you running e2e tests in? |
I put a debugger in the code and ran my e2e tests. Interestingly, |
I use Karma v0.10.8 and Chrome 34.0.1847 (Mac OS X 10.9.2) |
Are you including angular-scenario.js? |
No, just using the ng-scenario framework had worked for me before. Here's my current karma config file:
Am I supposed to load the |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
After upgrading from beta-1 to beta-4, all my E2E tests which use clicks break. Interestingly, it seems to work for button elements, but not for anchor elements. For example:
element('.class-on-some-button-element').click();
works as expectedelement('.class-on-some-anchor-element').click();
does not reflect click at allIs there a new click handler or something?
I'd really like to upgrade Ionic but this is holding me back.
The text was updated successfully, but these errors were encountered: