Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slidebox] slider-slides has a wrong width depending on the transition between 2 views #1313

Closed
dbaq opened this issue May 8, 2014 · 7 comments

Comments

@dbaq
Copy link

dbaq commented May 8, 2014

Hey guys,

The way that the slidebox witdh is computed is not working regarding the transition. In my transition, I am using scale(). The width is computed before the end of the transition (before scale=1), so the final width is wrong.

here is the codepen to illustrate the issue http://codepen.io/anon/pen/zGDwC, on the first view there is a slider with 2 slides, click the Facts button to go on the second view, click on the back button, you will be able to see the beginning of the 2nd slide now.

screen shot 2014-05-08 at 4 21 55 pm

ps: if I comment out the scale code in the transition, everything works fine.

any thoughts?

thanks for your help

@dbaq
Copy link
Author

dbaq commented May 31, 2014

Hey there,

@ajoslin, any updates on this issue? thanks

@dbaq
Copy link
Author

dbaq commented Jun 13, 2014

with the latest beta 7, the bug is even more present with the fade-implode css transition for the android platform. Any thoughts @mlynch since you worked on it?

@ajoslin
Copy link
Contributor

ajoslin commented Jun 23, 2014

I'll check this out.

@ajoslin
Copy link
Contributor

ajoslin commented Jun 24, 2014

Can you check it out with the latest commit?

The problem it was using getBoundingClientRect() to calculate the width, which takes scale into account when measuring the width.

@dbaq
Copy link
Author

dbaq commented Jun 24, 2014

Great :) I'll try it out tonight!

@dbaq
Copy link
Author

dbaq commented Jun 24, 2014

I confirm, it is fixed. Thank you @ajoslin!

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants